MSVC compatibility #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthohr
reviewed
Jun 16, 2022
src/unconstrained/de.cpp
Outdated
| @@ -117,7 +117,11 @@ optim::internal::de_impl( | |||
| #ifdef OPTIM_USE_OPENMP | |||
| #pragma omp parallel for num_threads(omp_n_threads) firstprivate(rand_vec) | |||
| #endif | |||
| #ifdef _MSC_VER | |||
There was a problem hiding this comment.
This is an ugly code change. I suggest using an alias that depends on the build system.
There was a problem hiding this comment.
Alright, this is done now (see commit (effb64) ).
kthohr
reviewed
Jun 16, 2022
src/unconstrained/de.cpp
Outdated
| @@ -117,7 +117,11 @@ optim::internal::de_impl( | |||
| #ifdef OPTIM_USE_OPENMP | |||
| #pragma omp parallel for num_threads(omp_n_threads) firstprivate(rand_vec) | |||
| #endif | |||
| #ifdef _MSC_VER | |||
There was a problem hiding this comment.
This is an ugly code change. I suggest using an alias that depends on the build system.
There was a problem hiding this comment.
Alright, this is done now (see commit (effb64) ).
|
Before proposing a code change like this, I suggest first opening an issue to discuss the proposal. In general, I have no need to support MSVC, and don't want to going forward, so I am not inclined to accept this (however minor the changes might be). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC support