Remove inheritance with the same name, too #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will test this tomorrow |
ktdreyer
reviewed
Oct 16, 2019
ktdreyer
reviewed
Oct 16, 2019
ktdreyer
reviewed
Oct 16, 2019
ktdreyer
reviewed
Oct 17, 2019
Koji won't allow a tag's parents to include two of the same name nor priority, so remove matches for either, instead of just priority. This will allow changing a parent's priority when another parent already has that priority, by removing both inheritance links before setting the desired one. It also allows removing inheritance link by either parent tag name or priority, as well as both (exact match).
|
Rebased on #68, improved commit message and documentation, and expanded test coverage. |
Prior to this change, we only tested deleting by parent_tag name.
Add tests to cover deleting by priority as well. Now we have four
scenarios:
delete-1: Delete by parent_tag name only
delete-2: Delete by priority only
delete-3: Delete by parent_tag name and priority
delete-4: Do *not* delete if parent_tag name and priority fail to
match
|
I think this is a lot easier to review now, thanks. If you rebase on master again, it'll be easier to see the single commit.
We need more integration tests for this behavior, so I added them as a pull request to your branch: https://github.com/ahills/koji-ansible/pull/1 |
Koji won't allow a tag's parents to include two of the same name nor priority, so remove matches for either, instead of just priority. This will allow changing a parent's priority.
tests: more delete tests for koji_tag_inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Koji won't allow a tag's parents to include two of the same name nor priority, so remove matches for either, instead of just priority. This will allow changing a parent's priority when another parent already has that priority, by removing both inheritance links before setting the desired one.
It also allows removing inheritance link by either parent tag name or priority, as well as both (exact match).