User EEPROM Compatibility #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwjohns4 I am sorry for the slow reply! Could you please check if the drawing below properly documents the changes?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the previous version to instead of setting a persistent flag, users can just add their EEPROM_SIZE to the constructor which is 0 by default. Then if user EEPROM is 0, then call .begin(_offset + _size) but only if the EEPROM is not already begun. This is checked by EEPROM.length(). If the value is not zero then that means the user sketch has already called .begin() and we should call it within this library or it could reallocate the buffer and result in loss of information.