chrome 120 run

krausest · Dec 7, 2023 · 5a14584 · 5a14584
1 parent 3064694
commit 5a14584
Show file tree

Hide file tree

Showing 12 changed files with 3,478 additions and 3,702 deletions.
diff --git a/startLocalServerAndUpdateBuild.sh b/startLocalServerAndUpdateBuild.sh
@@ -1,9 +1,10 @@
 # private file to copy the zip file from my VPS
 set -e
+git pull
 echo "running zip on js-framework-benchmark"
 ssh $VPS_HOST "cd js-framework-benchmark  && npm run zip"
 scp $VPS_HOST:/home/stefan/js-framework-benchmark/build.zip .
 unzip -o build.zip
 ssh $VPS_HOST "ls -l js-framework-benchmark/build.zip"
 ls -l build.zip
-npm start
+npm start
diff --git a/webdriver-ts-results/src/App.tsx b/webdriver-ts-results/src/App.tsx
@@ -44,7 +44,7 @@ const App = () => {
 
   const testEnvironmentInfo = (
     <p>
-      The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.1), Chrome 119.0.6045.105 (arm64) using
+      The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.1.2), Chrome 120.0.6099.62 (arm64) using
       the puppeteer benchmark driver with reduced tracing.
     </p>
   );

diff --git a/webdriver-ts-results/src/Common.ts b/webdriver-ts-results/src/Common.ts
@@ -13,8 +13,7 @@ export enum DisplayMode {
 export enum CpuDurationMode {
   Total = "total",
   Script = "script",
-  Render = "paint",
-  BrowserOnly = "browser only",
+  Render = "paint"
 }
 
 export enum FrameworkType {

diff --git a/webdriver-ts-results/src/components/ResultTable.tsx b/webdriver-ts-results/src/components/ResultTable.tsx
@@ -56,11 +56,6 @@ const ResultTable = ({ type }: Props) => {
             Report bugs in issue <a href="https://github.com/krausest/js-framework-benchmark/issues/1233">1233</a>.
           </h3>
         )}
-        {cpuDurationMode === CpuDurationMode.BrowserOnly && (
-          <h3>Warning: This is an experimental view that shows the difference between total duration and script duration. Don&apos;t rely on those values yet and don&apos;t report them until they are official.
-            I guess this view mode just makes no sense.
-          </h3>
-        )}
         {cpuDurationMode === CpuDurationMode.Render && (
           <h3>Warning: This is an experimental view that shows the difference between total duration and script duration. Don&apos;t rely on those values yet and don&apos;t report them until they are official.
             Report bugs in issue <a href="https://github.com/krausest/js-framework-benchmark/issues/1233">1233</a>.

diff --git a/webdriver-ts-results/src/components/selection/ModeSelectionPanel/DurationModeSelector.tsx b/webdriver-ts-results/src/components/selection/ModeSelectionPanel/DurationModeSelector.tsx
@@ -11,7 +11,7 @@ const DurationModeSelector = ({ cpuDurationMode, onChange }: Props) => {
     <>
       <div className="mode-selector">
         <label htmlFor="durationMode">
-          (Experimental) Duration measurement mode:
+          Duration measurement mode:
         </label>
         <select
           id="durationMode"
@@ -23,7 +23,6 @@ const DurationModeSelector = ({ cpuDurationMode, onChange }: Props) => {
           <option value={CpuDurationMode.Total}>total duration</option>
           <option value={CpuDurationMode.Script}>only JS duration</option>
           <option value={CpuDurationMode.Render}>only render duration</option>
-          <option value={CpuDurationMode.BrowserOnly}>Browser only duration</option>
         </select>
       </div>
     </>

diff --git a/webdriver-ts-results/src/reducer.ts b/webdriver-ts-results/src/reducer.ts
@@ -38,31 +38,6 @@ const results: Result[] = rawResults.map((result) => {
     };
     values[key] = vals;
   }
-  if (result.v[CpuDurationMode.Total] && result.v[CpuDurationMode.Script] && result.v[CpuDurationMode.Render]) {
-    if (result.v[CpuDurationMode.Total].length !== result.v[CpuDurationMode.Script].length) {
-      const vals = {
-        mean: NaN,
-        median: NaN,
-        standardDeviation: NaN,
-        values: [NaN],
-      };
-      debugger;
-      values[CpuDurationMode.BrowserOnly] = vals;
-    } else {
-      let r = [];
-      for (let i = 0; i < result.v[CpuDurationMode.Total].length; i++) {
-        r.push(result.v[CpuDurationMode.Total][i] - result.v[CpuDurationMode.Script][i]);
-      }
-      const vals = {
-        mean: jStat.mean(r),
-        median: jStat.median(r),
-        standardDeviation: jStat.stdev(r, true),
-        values: r,
-      };
-      values[CpuDurationMode.BrowserOnly] = vals;
-    }
-    // if (result.f==='miso-v1.4.0-keyed' || result.f==='vanillajs-keyed') debugger;
-  }
 
   return { framework: result.f, benchmark: result.b, results: values };
 });

diff --git a/webdriver-ts-results/src/results.ts b/webdriver-ts-results/src/results.ts
diff --git a/webdriver-ts/results.json b/webdriver-ts/results.json
diff --git a/webdriver-ts/src/benchmarksCommon.ts b/webdriver-ts/src/benchmarksCommon.ts
@@ -31,7 +31,6 @@ export interface SizeInfoJSON {
   size_uncompressed: number,
   size_compressed: number,
   fp: number,
-  fcp: number,
 }
 
 export interface SizeBenchmarkInfo extends BenchmarkInfoBase {

diff --git a/webdriver-ts/src/benchmarksSize.ts b/webdriver-ts/src/benchmarksSize.ts
@@ -35,20 +35,20 @@ export const benchFP: benchmarksCommon.SizeBenchmarkInfo = {
   fn: (sizeInfo) => Number(sizeInfo.fp.toFixed(1)),
 };
 
-export const benchFCP: benchmarksCommon.SizeBenchmarkInfo = {
-  id: "44_first-contentful-paint",
-  label: "first contentful paint",
-  description: () =>
-    "first contentful paint",
-  type: BenchmarkType.SIZE,
-  fn: (sizeInfo) => Number(sizeInfo.fcp.toFixed(1)),
-};
+// export const benchFCP: benchmarksCommon.SizeBenchmarkInfo = {
+//   id: "44_first-contentful-paint",
+//   label: "first contentful paint",
+//   description: () =>
+//     "first contentful paint",
+//   type: BenchmarkType.SIZE,
+//   fn: (sizeInfo) => Number(sizeInfo.fcp.toFixed(1)),
+// };
 
 export const subbenchmarks = [
   benchUncompressedSize,
   benchCompressedSize,
   benchFP,
-  benchFCP,
+  // benchFCP,
 ];
 
 export class BenchmarkSize implements BenchmarkImpl {

diff --git a/webdriver-ts/src/forkedBenchmarkRunnerSize.ts b/webdriver-ts/src/forkedBenchmarkRunnerSize.ts
@@ -71,7 +71,7 @@ async function runSizeBenchmark(
       let sizeInfo = (await sizeInfoResponse.json()) as SizeInfoJSON;
       console.log("sizeInfo", sizeInfo);
       sizeInfo.fp = paintEvents.find((e: any) => e.name === "first-paint").startTime;
-      sizeInfo.fcp = paintEvents.find((e: any) => e.name === "first-contentful-paint").startTime;
+      // sizeInfo.fcp = paintEvents.find((e: any) => e.name === "first-contentful-paint").startTime;
 
       results = benchmarks.subbenchmarks.map((b) => ({
           benchmark: b,

diff --git a/webdriver-ts/src/parseTrace.ts b/webdriver-ts/src/parseTrace.ts
@@ -5,14 +5,14 @@ import { computeResultsCPU, computeResultsJS, computeResultsPaint, parseCPUTrace
 
 async function debugSingle() {
   let values: number[] = [];
-  for (let i = 0; i < 15; i++) {
+  // for (let i = 0; i < 15; i++) {
     // const trace = `traces/anansi-v0.14.0-keyed_01_run1k_${i}.json`;
   // const trace = `traces/alpine-v3.12.0-keyed_07_create10k_${i}.json`;
   // const trace = `traces/alpine-v3.12.0-keyed_07_create10k_0.jsontraces/1more-v0.1.18-keyed_01_run1k_0.json`;
   // const trace = `traces/alpine-v3.12.0-keyed_07_create10k_0.json`;
   // const trace = `traces/arrowjs-v1.0.0-alpha.9-keyed_07_create10k_0.json`;
   // const trace = `traces/better-react-v1.1.3-keyed_04_select1k_1.json`;
-    const trace = `traces/malina-v0.7.3-keyed_01_run1k_${i}.json`;
+    const trace = `traces/openui5-v1.120.0-keyed_02_replace1k_0.json`;
     // const trace = `traces/vanillajs-keyed_01_run1k_0.json`;
     console.log("analyzing trace", trace);
     const cpuTrace = await computeResultsCPU(trace);
@@ -23,7 +23,7 @@ async function debugSingle() {
     let resultPaint = await computeResultsPaint(cpuTrace, config, trace);
     console.log("resultPaint", resultPaint);
 // console.log(trace, await computeResultsJS(cpuTrace, config, trace, DurationMeasurementMode.LAST_PAINT))
-  }
+  // }
   console.log(values);
   console.log(stats(values));
 }