update results for chrome 105

krausest · Sep 3, 2022 · 13b99ac · 13b99ac
1 parent 11058c0
commit 13b99ac
Show file tree

Hide file tree

Showing 10 changed files with 3,530 additions and 3,499 deletions.
diff --git a/webdriver-ts-results/src/App.tsx b/webdriver-ts-results/src/App.tsx
@@ -15,7 +15,7 @@ const App = (): JSX.Element => {
     return (
       <div>
         {disclaimer}
-        <p>The benchmark was run on a MaBook Air M1 (16 GB RAM, OSX 12.5), Chrome 104.0.5112.79 (arm64))
+        <p>The benchmark was run on a MaBook Air M1 (16 GB RAM, OSX 12.5), Chrome 105.0.5195.102 (arm64))
             using the puppeteer benchmark driver with reduced tracing.
         </p>
          <SelectionBar/>

diff --git a/webdriver-ts-results/src/Common.ts b/webdriver-ts-results/src/Common.ts
@@ -343,13 +343,19 @@ export class ResultTableData {
                 return result.mean;
             }
         }
-        const min = benchmarkResults.reduce((min, result) => result===null ? min : Math.min(min, selectFn(result)), Number.POSITIVE_INFINITY);
+        let min = Math.max(benchmarkResults.reduce((min, result) => result===null ? min : Math.min(min, selectFn(result)), Number.POSITIVE_INFINITY));
+        // if (benchmark.type === BenchmarkType.CPU) {
+        //     min = Math.max(1000/60, min);
+        // }
         return this.frameworks.map(f => {
             const result = this.results(benchmark, f);
             if (result === null) return null;
 
             const value = selectFn(result);
-            const factor = value/min;
+            let factor = value/min;
+            // if (benchmark.type === BenchmarkType.CPU) {
+            //     factor = Math.max(1, factor);
+            // }    
             const conficenceInterval = 1.959964 * (result.standardDeviation || 0) / Math.sqrt(result.values.length);
             const conficenceIntervalStr = benchmark.type === BenchmarkType.MEM ? null : conficenceInterval.toFixed(1);
             const formattedValue = formatEn.format(value);

diff --git a/webdriver-ts-results/src/results.ts b/webdriver-ts-results/src/results.ts
diff --git a/webdriver-ts-results/table.html b/webdriver-ts-results/table.html
diff --git a/webdriver-ts/package-lock.json b/webdriver-ts/package-lock.json
diff --git a/webdriver-ts/package.json b/webdriver-ts/package.json
@@ -17,35 +17,35 @@
   "author": "",
   "license": "Apache-2.0",
   "devDependencies": {
-    "@types/lodash": "4.14.182",
-    "@types/node": "18.6.3",
+    "@types/lodash": "4.14.184",
+    "@types/node": "18.7.14",
     "@types/ramda": "^0.28.15",
-    "@types/selenium-webdriver": "4.1.2",
-    "@types/semver": "7.3.10",
+    "@types/selenium-webdriver": "4.1.3",
+    "@types/semver": "7.3.12",
     "@types/underscore": "^1.11.4",
-    "@types/yargs": "17.0.10",
-    "@typescript-eslint/eslint-plugin": "^5.32.0",
-    "@typescript-eslint/parser": "^5.32.0",
-    "dockerode": "^3.3.3",
-    "eslint": "^8.21.0",
+    "@types/yargs": "17.0.12",
+    "@typescript-eslint/eslint-plugin": "^5.36.1",
+    "@typescript-eslint/parser": "^5.36.1",
+    "dockerode": "^3.3.4",
+    "eslint": "^8.23.0",
     "rimraf": "^3.0.2",
     "ts-node": "10.9.1",
-    "typescript": "4.7.4"
+    "typescript": "4.8.2"
   },
   "dependencies": {
     "axios": "^0.27.2",
-    "chromedriver": "^103.0.0",
+    "chromedriver": "^105.0.0",
     "cross-env": "7.0.3",
     "dot": "1.1.3",
     "jstat": "1.9.5",
-    "lighthouse": "9.6.5",
+    "lighthouse": "9.6.7",
     "lodash": "4.17.21",
     "marky": "^1.2.5",
-    "npm-check-updates": "16.0.5",
-    "playwright": "^1.24.2",
-    "puppeteer-core": "^15.5.0",
+    "npm-check-updates": "16.0.6",
+    "playwright": "^1.25.1",
+    "puppeteer-core": "^17.1.0",
     "ramda": "^0.28.0",
-    "selenium-webdriver": "4.3.1",
+    "selenium-webdriver": "4.4.0",
     "semver": "7.3.7",
     "underscore": "^1.13.4",
     "yargs": "17.5.1"

diff --git a/webdriver-ts/results.json b/webdriver-ts/results.json
diff --git a/webdriver-ts/src/benchmarksPuppeteer.ts b/webdriver-ts/src/benchmarksPuppeteer.ts
@@ -249,6 +249,7 @@ export const benchUpdate5Memory = new (class extends MemBenchmarkPuppeteer {
   }
   async run(page: Page) {
     await clickElement(page, "pierce/#run");
+    await checkElementExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(2)>a");
     for (let i = 0; i < 5; i++) {
       await clickElement(page, "pierce/#update");
       await checkElementContainsText(page, "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(2)>a", " !!!".repeat(i));

diff --git a/webdriver-ts/src/forkedBenchmarkRunnerPlaywright.ts b/webdriver-ts/src/forkedBenchmarkRunnerPlaywright.ts
@@ -170,7 +170,7 @@ async function runMemBenchmark(
         });
       }
 
-      await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`);
+      await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`, {waitUntil: "networkidle"});
 
       // await (driver as any).sendDevToolsCommand('Network.enable');
       // await (driver as any).sendDevToolsCommand('Network.emulateNetworkConditions', {

diff --git a/webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts b/webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts
@@ -127,7 +127,7 @@ async function runCPUBenchmark(framework: FrameworkData, benchmark: CPUBenchmark
             // let m1 = await page.metrics();
             await runBenchmark(page, benchmark, framework);
 
-            await wait(10);
+            await wait(40);
             await page.tracing.stop();
             // let m2 = await page.metrics();
             if (benchmark.benchmarkInfo.throttleCPU) {
@@ -181,8 +181,8 @@ async function runMemBenchmark(
           for (let i = 0; i < msg.args().length; ++i) console.log(`BROWSER: ${msg.args()[i]}`);
         });
       }
-
-      await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`);
+      
+      await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`, {waitUntil: "networkidle0"});
 
       // await (driver as any).sendDevToolsCommand('Network.enable');
       // await (driver as any).sendDevToolsCommand('Network.emulateNetworkConditions', {