WorkloadIdentityBinding: permissions to read namespaces, write IAMPolicyMembers #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to get the project-id annotation from the namespace.
justinsb
requested review from
droot,
mengqiy,
mortent,
natasha41575 and
yuwenma
as code owners
justinsb
changed the title
mortent
reviewed
Aug 25, 2022
| @@ -26,6 +26,14 @@ rules: | |||
| verbs: | |||
| - create | |||
| - patch | |||
| - apiGroups: | |||
There was a problem hiding this comment.
Currently the porch make targets doesn't use this file directly, but rather use the rbac from https://github.com/GoogleContainerTools/kpt/blob/main/porch/deployments/porch/9-controllers.yaml#L57. I'm meaning to fix this, but until that is fixed we need to update the rbac rules directly in that file.
yuwenma
reviewed
Aug 25, 2022
| //+kubebuilder:rbac:groups="",resources=namespaces,verbs=get;list;watch | ||
|
|
||
| // Creates iampolicymembers (using server-side-apply) | ||
| //+kubebuilder:rbac:groups=iam.cnrm.cloud.google.com,resources=iampolicymembers,verbs=get;list;watch;create;update;patch;delete |
There was a problem hiding this comment.
oh, this looks really cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get the project-id annotation from the namespace, and we need permission to create IAMPolicyMembers