Protect error read with the RLock too

Signed-off-by: John Belamaric <[email protected]>

porch/pkg/cache/cache.go

@@ -142,8 +142,13 @@ func (c *Cache) OpenRepository(ctx context.Context, repositorySpec *configapi.Re
 				cr = newRepository(key, repositorySpec, r, c.objectNotifier, c.metadataStore, c.repoSyncFrequency)
 				c.repositories[key] = cr
 			}
+		} else {
+			// If there is an error from the background refresh goroutine, return it.
+			if err := cr.getRefreshError(); err != nil {
+				return nil, err
+			}
 		}
-		return cr, cr.refreshRevisionsError
+		return cr, nil
 
 	default:
 		return nil, fmt.Errorf("type %q not supported", repositoryType)

porch/pkg/cache/repository.go

@@ -118,6 +118,13 @@ func (r *cachedRepository) ListFunctions(ctx context.Context) ([]repository.Func
 	return functions, nil
 }
 
+func (r *cachedRepository) getRefreshError() error {
+	r.mutex.RLock()
+	defer r.mutex.RUnlock()
+
+	return r.refreshRevisionsError
+}
+
 func (r *cachedRepository) getPackageRevisions(ctx context.Context, filter repository.ListPackageRevisionFilter) ([]repository.PackageRevision, error) {
 	packageRevisions, err := r.getCachedPackageRevisions(ctx)
 	if err != nil {