Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell configuration, workflow, pre-commit config and fix few typos #1842

Merged
merged 10 commits into from
Feb 13, 2024

Conversation

yarikoptic
Copy link
Contributor

Signed-off-by: Yaroslav Halchenko <[email protected]>
Signed-off-by: Yaroslav Halchenko <[email protected]>
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^

Signed-off-by: Yaroslav Halchenko <[email protected]>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@edaa234). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1842   +/-   ##
=======================================
  Coverage        ?   98.98%           
=======================================
  Files           ?       37           
  Lines           ?     4156           
  Branches        ?      968           
=======================================
  Hits            ?     4114           
  Misses          ?       26           
  Partials        ?       16           
Flag Coverage Δ
unittests 98.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 7, 2024

CodSpeed Performance Report

Merging #1842 will not alter performance

Comparing yarikoptic:enh-codespell (34c15d7) with main (edaa234)

Summary

✅ 29 untouched benchmarks

@yarikoptic
Copy link
Contributor Author

sorry I have not tested pre-commit functioning correctly... we are running into

I will add explicit exclude within pre-commit config now

@koxudaxi
Copy link
Owner

koxudaxi commented Feb 7, 2024

@yarikoptic
Thank you for creating the PR!!
OK, I will come back after you change.

@yarikoptic
Copy link
Contributor Author

I already did... I didn't check if fails if other ci runs relate

@koxudaxi koxudaxi merged commit 2d0f900 into koxudaxi:main Feb 13, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants