All functions that take a Census API key as an argument now use Sys.getenv("CENSUS_API_KEY") by default
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `CENSUS_API_KEY` envvar
…s for getting an API key
…KEY` environment variable
Docs/improvements
…-tract fix(voters): use tract NY-061-014900 instead of 015100
|
Closing here, merging into dev in #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all functions that take a Census API key as an argument now use
Sys.getenv("CENSUS_API_KEY")as their default value. This moves logic that was previously internal to the function for handlingNULLvalues into the function signature.Package documentation now also makes explicit that this environment variable is checked by default. Previously, this behavior was not documented in many functions that used
NULLas their default value.This PR adds
cliandrlangto the list of package dependencies, but these packages were already implicit dependencies, because they are depended on by pre-existing dependencies likedplyrandpurrr.