Cleanup whole codebase

[Pringlers]

Please squash merge it to remove inconsistent commit messages later

Goals

This PR is intended to clean up the entire codebase.

• Create, modify, or remove the classes for better maintainability
• Adopt more efficient logic
• Remove duplicated code
• Write idiomatic TypeScript

Non-Goals

• Change website appearance
• Create API v3
• Change DB structure

[Pringlers]

@skinmaker1345 There are more changes to be made in this PR, or do you want me to split this into multiple PRs?

[Pringlers]

Type rework fixed every relevant type error.

Most of the changes in components are as simple as removing type assertions (e.g. (bot.users as User[])).
Components that only operate on partial data now require the type of XXX<true|false>

[Pringlers]

XXXTable – 1:1 mapping of SQL query result. JSON fields are not parsed yet
BaseXXX – Same, but JSON fields are parsed
XXX<Nested> – Nested indicates whether it has fully resolved children or snowflakes.

[skinmaker1345]

Looks great, except
@Pringlers your code seems to fetch nested objects, always, even for raw objects

[skinmaker1345]

we are aware of that, what's the ts version you're running., by chance?

[Pringlers]

your code seems to fetch nested objects, always, even for raw objects

Can you point out where it does? I moved code to resolve children into getXXX, and _rawXXX DataLoaders now call getNestedXXX(id) directly if you mean that

we are aware of that, what's the ts version you're running., by chance?

4.9.5

[skinmaker1345]

Can you point out where it does? I moved code to resolve children into getXXX, and _rawXXX DataLoaders now call getNestedXXX(id) directly if you mean that

think i confused each other, you did refactor as expected, apologies.

4.9.5

using 4.6.x resolves the issue(if you're having trouble with it), 4.6.4 is the version which we specify to use

[skinmaker1345]

@Pringlers Do you have any works to be done?

[Pringlers]

Yes I do, but it might take long to get them done. So feel free to merge it if you want to work on top of these changes

[skinmaker1345]

We need to know what will be changed.We already have plans to rewrite, and we would like to limit your job since your works might be disposed.

[skinmaker1345]

Hi, I am afraid to tell that this pr should be closed as we are preparing to apply a formatter for entire codebase.