Screen rotate support for new ui #732
Conversation
So we only need to change widget dimen on SetDimensions event
| @@ -26,7 +26,9 @@ KoptOptions = { | |||
| name="screen_mode", | |||
| name_text = "Screen Mode", | |||
| item_text = {"portrait", "landscape"}, | |||
There was a problem hiding this comment.
Merge conflicted at this line. In the new_ui_code branch it ought to be toggle = {"portrait", "landscape"},
CONFLICT (content): Merge conflict in frontend/document/koptinterface.lua
There was a problem hiding this comment.
Yeah, that's the problem. The default arg for this toggle should be decided on run time. So far the only solution I can think of is to set this up by changing self.options in ReaderConfig's onSetDimensions handler.
Is it the right way to do so?
There was a problem hiding this comment.
It looks good. We should also see if it will work.
There was a problem hiding this comment.
I still think at some point we need to move the config options in koptdocument and credocument to ui components.
For example, for this screen rotate feature, it's entirely not related to document data, so it dosen't make much sense to put it in *document.lua, since *document.lua should only provide document manipulation APIs.
Also some of these options has attributes like width , height, font size, font, font text, etc, which are also document independent.
config dialog UI is very handy so we might need to use it in somewhere else not just for reader, for example: help page, file chooser (Other devices like Kobo need this), etc. These are all document independent features so where should we put the option definitions then?
Yes, your previous point is correct, all these attributes are like css, thus should not put into UI implementation code. Then how about making something like a ui-data directory and put related options definition there?
There was a problem hiding this comment.
Moving config options to a separate file is a good idea. We could think about the clean up work later.
There was a problem hiding this comment.
No, it doesn't work. I even try to set the default_arg in readerui.lua, before calling ReaderConfig:new, I still get following error:
# toggle position: 2
lua config error: ./frontend/ui/config.lua:238: attempt to perform arithmetic on field 'position' (a nil value)
More hints on how to use toggle?
…tate Conflicts: frontend/document/koptinterface.lua
|
It works great on emulator. I will then test it on paperwhite. |
|
Wait, it's broken right now. The toggle is blank and when I click on it I get following error: I still cannot find a way to set default_args on run time... |
|
Probably we can set default_args |
|
@chrox , good idea, this is much cleaner 👍 Don't merge it yet as I am working on some other fixes. |
This fix might only work for KPW, need to test on other devies later.
…tate Conflicts: frontend/ui/reader/readerconfig.lua
It's quite a big patch, I partially rewrote the screen and touch input module. Basically the internal API changed a lot.
The new implementation is based on the idea from @dracodoc, as discussed in #573. The screen rotation feature is device independent now, i.e. it don't need to interact with kindle framework any more. That's means it will work for other devices like Kobo and there will be no more glitches when switching into/out of screen saver :)
However, it's actually not finished yet. There are still a couple of small bugs that need to be fixed. I would like to send out the PR first so if some one else plan to work on the input or output module will be notified of the changes.