Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation about how to delete over-resource-used pods… #139

Merged

Conversation

jiasheng55
Copy link
Contributor

… in elastic quota management (#138)

@hormes
Copy link
Member

hormes commented Jul 11, 2023

@buptcozy please review this pr

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jiasheng55
Copy link
Contributor Author

/assign @eahydra

@jiasheng55
Copy link
Contributor Author

@hormes @buptcozy @eahydra Could you help to finish the review process.

@eahydra
Copy link
Member

eahydra commented Aug 1, 2023

@jiasheng55 hi, missing DCO, you can append signature as follows

$ git commit -s --amend --no-edit
$ git push -f

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Aug 2, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e0143c1 into koordinator-sh:main Aug 2, 2023
3 checks passed
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants