Яценко Ирина #219
Open
Яценко Ирина #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnovikova
reviewed
Dec 6, 2023
dmnovikova
reviewed
Dec 6, 2023
dmnovikova
reviewed
Dec 6, 2023
Поменяла модификаторы доступа для методов которые используются только внутри класса CircularCloudLayouter
dmnovikova
reviewed
Dec 11, 2023
|
На будущее: "реализация 2 и 3 задачи" — плохое название коммита Лучше в название закладывать фичу, добавленную в коммите: "добавила визуализацию облака ..." |
dmnovikova
reviewed
Dec 11, 2023
|
|
||
| namespace TagsCloudVisualization | ||
| { | ||
| public class TagCloudCreator |
There was a problem hiding this comment.
плохое название, т.к. класс не создает облако, а отрисовывает его
There was a problem hiding this comment.
на мой взгляд, visualizer или drawer более очевидные названия
|
Зачтено ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dmnovikova