Бабин Георгий #218
Open
Бабин Георгий #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on this feature
…ted drawing into separate class
69raccoon96
suggested changes
Dec 5, 2023
| public void DrawShape() | ||
| { | ||
| var center = new Point(image.Width / 2, image.Height / 2); | ||
| var radius = (int)layouter.Rectangles.Select(x => Math.Sqrt(Math.Pow(x.X - center.X, 2) + Math.Pow(x.Y - center.Y, 2))).Max(); |
There was a problem hiding this comment.
Слишком длинная строка, логично было бы вынести в отдельный метод, возможно даже в метод расширения
| { | ||
| var center = new Point(image.Width / 2, image.Height / 2); | ||
| var radius = (int)layouter.Rectangles.Select(x => Math.Sqrt(Math.Pow(x.X - center.X, 2) + Math.Pow(x.Y - center.Y, 2))).Max(); | ||
| graphics.DrawEllipse(Pens.Brown, new Rectangle(new Point(center.X - radius, center.Y - radius), new Size(radius * 2, radius * 2))); |
There was a problem hiding this comment.
А здесь тяжело читается из-за того, что создаешь прямоугольник прямо внутри метода, возможно лучше в отдельную переменную вынести
There was a problem hiding this comment.
Вообще как будто самым логичным вариантом будет создать здесь отдельного "поставщика" точек, в которых нужно нарисовать фигуру
| graphics.Save(); | ||
| } | ||
|
|
||
| public void SaveImage(string filename) |
There was a problem hiding this comment.
Это не ответственность визуализатора
|
|
||
| protected BaseCloudLayouter(Point center) | ||
| { | ||
| this.center = center; |
There was a problem hiding this comment.
А если центр будет иметь отрицательные координаты?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@69raccoon96