Яценко Ирина #198

lholypeachy · 2023-12-25T20:25:33Z

No description provided.

gisinka · 2023-12-25T20:29:08Z

ObjectPrinting/PrintingConfig.cs

@@ -1,40 +1,156 @@
 using System;


Все комменты обсуждаемы - можем обсуждать или в тредах, или в личке в телеге
За количество комментов не парься - это нормально, процесс обучения, повышения скилла, ревью именно для этого и нужно

На пофикшенные комментарии можно ставить реакции или писать пометочки, что и почему

ObjectPrinting/PrintingConfig.cs

+        {
+            Func<string, string> func = value => value.Length <= length
+                ? value
+                : value.Substring(0, length);


ObjectPrinting/PrintingConfig.cs

            if (finalTypes.Contains(obj.GetType()))
                return obj + Environment.NewLine;

+            if (!complexObjectLinks.ContainsKey(obj))


ObjectPrinting/PrintingConfig.cs

        private string PrintToString(object obj, int nestingLevel)
        {
-            //TODO apply configurations
            if (obj == null)
                return "null" + Environment.NewLine;


ObjectPrinting/PrintingConfig.cs

+            complexObjectLinks[obj]++;
+
+            if (complexObjectLinks[obj] == maxRecursion)
+                return "Maximum recursion has been reached" + Environment.NewLine;


ObjectPrintingTests/ObjectPrinterAcceptanceTests.cs

+        }
+
+        [Test]
+        public void TrimString_ShouldReturnSubstring()


ObjectPrintingTests/ObjectPrinterAcceptanceTests.cs

+    public class ObjectPrinterAcceptanceTests
+    {
+        [Test]
+        public void WhenExcludeType_ShouldReturnWithoutThisType()


ObjectPrintingTests/ObjectPrinterAcceptanceTests.cs

+namespace ObjectPrintingTests
+{
+    [TestFixture]
+    public class ObjectPrinterAcceptanceTests


ObjectPrinting/PrintingConfig.cs

+
+                if (membersSerializesInfos.TryGetValue(propertyInfo, out var serializeMember))
+                {
+                    var t = serializeMember(propertyInfo.GetValue(obj));


gisinka · 2023-12-25T21:30:15Z

ObjectPrinting/PrintingConfig.cs

+
+            if (complexObjectLinks[obj] == maxRecursion)
+                return "Maximum recursion has been reached" + Environment.NewLine;
+
            var identation = new string('\t', nestingLevel + 1);


Го заюзаем ради интереса string.Intern(), это позволит избежать лишних аллокаций

Если хранить в ста или, что еще хуже, в миллионе строковых переменных одинаковое значение получится, что память для хранения значений строк будет выделяться снова и снова. Интернирование строки это способ обойти эту проблему

ObjectPrinting/PrintingConfig.cs

-                sb.Append(identation + propertyInfo.Name + " = " +
-                          PrintToString(propertyInfo.GetValue(obj),
-                              nestingLevel + 1));
+                DataMember data = new DataMember(propertyInfo);


ObjectPrinting/PrintingConfig.cs

        }

+        private void HandleMember(StringBuilder sb, DataMember member, object obj, string indentation, int nestingLevel)


gisinka · 2023-12-26T10:22:06Z

ObjectPrinting/PrintingConfig.cs

-                sb.Append($"{indentation}{propertyInfo.Name} = " +
-                          PrintToString(propertyInfo.GetValue(obj),
-                              nestingLevel + 1));
+                DataMember data = new DataMember(propertyInfo);


у тебя просто propertyInfo заворачивается в DataMember - зачем? Почему бы не просто передавать MemberInfo в метод

А еще можно сделать финт ушами, чтобы по разному не обрабатывать поля и свойства:

const BindingFlags bindingFlags = BindingFlags.Public | BindingFlags.Instance; var fields = type.GetFields(bindingFlags); var properties = type.GetProperties(bindingFlags); return fields.Concat<MemberInfo>(properties);

ObjectPrinting/PrintingConfig.cs

 using System.Linq;
+using System.Linq.Expressions;
+using System.Reflection;
 using System.Text;

 namespace ObjectPrinting
 {
    public class PrintingConfig<TOwner>


Реализация основных требований

871837c

gisinka suggested changes Dec 25, 2023

View reviewed changes

lholypeachy added 2 commits December 26, 2023 06:13

Исправление ошибок

767afb5

Добавлена возможность сериализации публичных полей

6432b58

gisinka reviewed Dec 26, 2023

View reviewed changes

ObjectPrinting/PrintingConfig.cs Outdated

sb.Append(identation + propertyInfo.Name + " = " +

PrintToString(propertyInfo.GetValue(obj),

nestingLevel + 1));

DataMember data = new DataMember(propertyInfo);

This comment was marked as resolved.

Sign in to view

gisinka reviewed Dec 26, 2023

View reviewed changes

ObjectPrinting/PrintingConfig.cs Outdated

}

private void HandleMember(StringBuilder sb, DataMember member, object obj, string indentation, int nestingLevel)

This comment was marked as resolved.

Sign in to view

gisinka reviewed Dec 26, 2023

View reviewed changes

ObjectPrinting/PrintingConfig.cs

using System.Linq;

using System.Linq.Expressions;

using System.Reflection;

using System.Text;

namespace ObjectPrinting

{

public class PrintingConfig<TOwner>

This comment was marked as resolved.

Sign in to view

lholypeachy added 8 commits December 26, 2023 17:51

Создана абстракция для сериализации

0aae76d

Исправлен Fluent интерфейс

d14c11a

Добавлена возможность задавать поведение при циклических ссылках

3a465c2

Корректная обработка циклических ссылок между объектами

4a2ac35

Реализована сериализация коллекций

59e3400

Рефакторинг кода

b64fd61

Добавлены новые тестовые случаи

5a18f9c

Новые тестовые случаи и рефакторинг кода

230d3cb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Яценко Ирина #198

Яценко Ирина #198

lholypeachy commented Dec 25, 2023

gisinka Dec 25, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

gisinka Dec 25, 2023 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

gisinka Dec 26, 2023

This comment was marked as resolved.

		}

		private void HandleMember(StringBuilder sb, DataMember member, object obj, string indentation, int nestingLevel)

Яценко Ирина #198

Are you sure you want to change the base?

Яценко Ирина #198

Conversation

lholypeachy commented Dec 25, 2023

gisinka Dec 25, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

gisinka Dec 25, 2023 • edited Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

gisinka Dec 26, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

gisinka Dec 25, 2023 •

edited

Loading