Козлов Данил #185

SenyaPevko · 2023-12-24T06:09:48Z

ObjectPrinting/ObjectPrinting.csproj

ObjectPrinting/PrintingConfig.cs

    {
+        private readonly SerializationSettings _serializationSettings;


ObjectPrinting/PrintingConfig.cs

+
+        public PrintingConfig()
+        {
+            _serializationSettings = new SerializationSettings();


SenyaPevko · 2023-12-26T19:08:42Z

ObjectPrinting/SerializationSettings.cs

+
+        public HashSet<Type> GetFinalTypes()
+        {
+            return _finalTypes;


убрал доступ к публичным полям

SenyaPevko · 2023-12-26T19:08:13Z

ObjectPrinting/SerializationSettings.cs

+            typeof(DateTime), typeof(TimeSpan)
+        };
+
+        private readonly Dictionary<Type, CultureInfo> _cultureForType;


исправил

SenyaPevko · 2023-12-26T19:01:55Z

ObjectPrinting/Serializer.cs

+            if (TrySerializeCollection(obj, nestingLevel, out var collectionSerialization))
+                return collectionSerialization;
+
+            if (settings.GetSerializedObjects().Contains(obj))


изменил отлов рекурсии. Добавил тест как на картинке

ObjectPrinting/Tests/ObjectPrinterAcceptanceTests.cs

+        private Person _person;
+
+        [Test]
+        public void PrintToString_ShouldReturnStringWithEveryObjectProperty()


SenyaPevko · 2023-12-26T19:00:53Z

ObjectPrinting/Tests/ObjectPrinterAcceptanceTests.cs


+        [Test]


добавил

ObjectPrinting/PrintingConfig.cs

+            return serializer.SerializeObject(obj, nestingLevel);
+        }
+
+        private string PrintEnumerableToString(IEnumerable<TOwner> enumerable)


SenyaPevko · 2023-12-26T19:00:32Z

ObjectPrinting/PropertyPrintingConfigExtension.cs

+    public static class PropertyPrintingConfigExtension
+    {
+        public static PrintingConfig<TOwner> TrimmedToLength<TOwner>(
+            this PropertyPrintingConfig<TOwner, string> propConfig, int length)


сделал выбрасывание ошибки на такой случай

gisinka · 2023-12-25T18:04:40Z

Все комменты обсуждаемы - можем обсуждать или в тредах, или в личке в телеге

На пофикшенные комментарии можно ставить реакции или писать пометочки, что сделал и почему

ObjectPrinting/Serializer.cs

+            if (TrySerializeFinalType(obj, out var typeSerialization))
+                return typeSerialization;
+
+            var identation = new string('\t', nestingLevel + 1);


gisinka · 2023-12-25T18:08:58Z

ObjectPrinting/Serializer.cs

+            {
+                if (!TrySerializeProperty(propertyInfo, obj, nestingLevel, out var propertySerialization))
+                    continue;
+                objectSerialization.Append(identation + propertyInfo.Name + " = " + propertySerialization +


Надо повыпиливать конкатенацию

ObjectPrinting/Serializer.cs

+        private bool TrySerializeProperty(PropertyInfo propertyInfo, object obj, int nestingLevel,
+            out string serializedProperty)
+        {
+            serializedProperty = "";


ObjectPrinting/Serializer.cs

+            if (settings.GetFinalTypes().Contains(type))
+            {
+                serializedType = obj.ToString();
+                if (settings.GetTypesWithCulture().ContainsKey(obj.GetType()) && obj is IFormattable)


SenyaPevko · 2023-12-26T18:59:59Z

ObjectPrinting/Serializer.cs

+            var identation = new string('\t', nestingLevel + 1);
+            var objectSerialization = new StringBuilder();
+            objectSerialization.AppendLine(type.Name);
+            foreach (var propertyInfo in type.GetProperties())


добавил сериализацию полей

ObjectPrinting/PrintingConfig.cs

+            return new PropertyPrintingConfig<TOwner, TPropType>(this, propertyInfo);
+        }
+
+        public PrintingConfig<TOwner> PrintRecursion(Exception exception)


gisinka · 2023-12-27T19:32:23Z

ObjectPrinting/MemberInfoExtension.cs

+
+namespace ObjectPrinting
+{
+    public static class MemberInfoExtension


internal, это ведь твоя внутрянка

gisinka · 2023-12-27T19:33:04Z

ObjectPrinting/PropertyPrintingConfig.cs

+
+        public PropertyPrintingConfig<TOwner, TPropType> Using(Func<dynamic, string> printProperty)
+        {
+            propertiesSerialization.TryAdd(propertyInfo, printProperty);


Не совсем понял, почему именно Try, может затирать?

gisinka · 2023-12-27T19:35:18Z

ObjectPrinting/Tests/Person.cs

@@ -5,8 +5,11 @@ namespace ObjectPrinting.Tests
    public class Person
    {
        public Guid Id { get; set; }
+


Можно и без пустых строк

gisinka · 2023-12-27T19:42:52Z

ObjectPrinting/PrintingConfig.cs

        }

-        private string PrintToString(object obj, int nestingLevel)
+        private string SerializeObject(object obj, IImmutableList<object> previousObjects)


Немного пересложнил, здесь явно нужна некоторая декомпозиция, мб вынос в отдельную абстракцию сериалайзера

gisinka · 2023-12-27T19:44:02Z

ObjectPrinting/Tests/ObjectPrinterTests.cs

+        {
+            var firstStudent = new Student { Name = "Alex", Age = 10 };
+            var secondStudent = new Student { Name = "Miha", Age = 15 };
+            var thirdstudent = new Student { Name = "Petr", Age = 12 };


Нужно немного поработать с неймингом, периодически переменные в тестах имеют длинные названия, что понижает читаемость, иногда теряется camelCase

SenyaPevko added 4 commits December 24, 2023 12:41

added tests for PrintingConfig

cdfbfce

added serializer

593adff

added printing config logic

56c0639

refactored code

4b029ce

gisinka suggested changes Dec 25, 2023

View reviewed changes

gisinka reviewed Dec 25, 2023

View reviewed changes

ObjectPrinting/Serializer.cs Outdated

if (TrySerializeFinalType(obj, out var typeSerialization))

return typeSerialization;

var identation = new string('\t', nestingLevel + 1);

This comment was marked as resolved.

Sign in to view

gisinka reviewed Dec 25, 2023

View reviewed changes

ObjectPrinting/Serializer.cs Outdated

private bool TrySerializeProperty(PropertyInfo propertyInfo, object obj, int nestingLevel,

out string serializedProperty)

{

serializedProperty = "";

This comment was marked as resolved.

Sign in to view

gisinka reviewed Dec 25, 2023

View reviewed changes

ObjectPrinting/Serializer.cs Outdated

if (settings.GetFinalTypes().Contains(type))

{

serializedType = obj.ToString();

if (settings.GetTypesWithCulture().ContainsKey(obj.GetType()) && obj is IFormattable)

This comment was marked as resolved.

Sign in to view

gisinka reviewed Dec 25, 2023

View reviewed changes

refactored

2a7369f

gisinka suggested changes Dec 26, 2023

View reviewed changes

ObjectPrinting/PrintingConfig.cs Outdated

return new PropertyPrintingConfig<TOwner, TPropType>(this, propertyInfo);

}

public PrintingConfig<TOwner> PrintRecursion(Exception exception)

This comment was marked as resolved.

Sign in to view

refactored after feedback

a68eb7c

gisinka reviewed Dec 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Козлов Данил #185

Козлов Данил #185

SenyaPevko commented Dec 24, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

SenyaPevko Dec 26, 2023

This comment was marked as resolved.

SenyaPevko Dec 26, 2023

This comment was marked as resolved.

This comment was marked as resolved.

SenyaPevko Dec 26, 2023

This comment was marked as resolved.

This comment was marked as resolved.

SenyaPevko Dec 26, 2023

This comment was marked as resolved.

This comment was marked as resolved.

SenyaPevko Dec 26, 2023

gisinka commented Dec 25, 2023

This comment was marked as resolved.

gisinka Dec 25, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

SenyaPevko Dec 26, 2023

This comment was marked as resolved.

gisinka Dec 27, 2023

gisinka Dec 27, 2023

gisinka Dec 27, 2023

gisinka Dec 27, 2023

gisinka Dec 27, 2023

		{
		private readonly SerializationSettings _serializationSettings;

Козлов Данил #185

Are you sure you want to change the base?

Козлов Данил #185

Conversation

SenyaPevko commented Dec 24, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

gisinka commented Dec 25, 2023

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment