fix: delete k1dir instead of kubeconfig file #2317
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndietz
reviewed
Nov 4, 2024
| if _, err := os.Stat(config.K1Dir + "/kubeconfig"); !os.IsNotExist(err) { | ||
| if err := os.Remove(config.K1Dir + "/kubeconfig"); err != nil { | ||
| return fmt.Errorf("unable to delete %q: %w", config.K1Dir+"/kubeconfig", err) | ||
| if _, err := os.Stat(config.K1Dir); !os.IsNotExist(err) { |
There was a problem hiding this comment.
i understand the desire to remove the k1dir. i want to also question that this is a change instead of an addition. why don't we want to remove the kubeconfig any longer?
There was a problem hiding this comment.
the ultimate goal to make a k3d provisioning possible again is to to remove the directory,i am not sure what was the thought behind removing kubeconfig,but this change should work smoothly for k3d reprovisioning
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when we do "kubefirst k3d destroy",it doesnt delete the k1dir repo which return an error that "repo already exists" when we try to provision a k3d cluster again