Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Azure usage #812

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Document Azure usage #812

merged 10 commits into from
Nov 13, 2024

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Oct 31, 2024

Description

Add the documentation for Azure. As with everything, this has been based on the Civo stuff but Azurified.

Couple of notes:

  • I would favour publishing Azure when we release v2.8 docs not v2.7. It's in from 2.7.4, so could be confusing if we get support requests for 2.7.0~3
  • there are some outstanding images required. This shouldn't be published until they're added to this PR

As always, happy to do demos if required.

Related Issue(s)

Fixes #797

How to test

Run npm start and read things under the "Azure" tab.

@fharper
Copy link
Contributor

fharper commented Nov 6, 2024

Azure docs shouldn't be in 2.7 unless it's already release in 2.7.x. For now, it should only reside in v.next (the docs folder, not in any versioned_docs). If we release azure in 2.7.x, we will do what the last commit to this PR does, but if it's in a 2.8.X release, we will create a new docs version for 2.8, and automatically it will have Azure content as the new version for docs are a copy of v.next. Happy to discuss more if it's not clear. I created an issue to clarify how and where to add new feature docs #820 as it's not clear if you don't own the docs, sorry

@konstructcarrie
Copy link
Contributor

@mrsimonemms Added some edits for ticky-tack language stuff. Otherwise LGTM 👍

docs/azure/overview.mdx Outdated Show resolved Hide resolved
konstructcarrie
konstructcarrie previously approved these changes Nov 7, 2024
Copy link
Contributor

@konstructcarrie konstructcarrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (with the caveat that this is merged into the versioning that @fharper suggested) I believe this is in the right "place"

@fharper fharper merged commit 67fedb0 into main Nov 13, 2024
13 checks passed
@fharper fharper deleted the sje/azure branch November 13, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure documentation
3 participants