Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: k3d Rancher Desktop #342

Merged
merged 5 commits into from
Jul 10, 2023
Merged

feat: k3d Rancher Desktop #342

merged 5 commits into from
Jul 10, 2023

Conversation

claywd
Copy link
Contributor

@claywd claywd commented Jun 29, 2023

Updates docs on k3d local and https flow.

@github-actions
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@claywd claywd changed the title Https k3d rancher desktop feat: Https k3d rancher desktop Jun 29, 2023
@fharper
Copy link
Contributor

fharper commented Jun 29, 2023

@claywd: can you sign the commits please, and I'll review it after.

@claywd claywd force-pushed the https_k3d_rancher_desktop branch from cfb4631 to 8e0ac57 Compare June 29, 2023 15:19
@github-actions
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

1 similar comment
@github-actions
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@claywd claywd force-pushed the https_k3d_rancher_desktop branch from f741ff6 to b508f36 Compare June 29, 2023 16:02
@github-actions
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@claywd claywd force-pushed the https_k3d_rancher_desktop branch from b508f36 to 78bc126 Compare June 29, 2023 16:11
Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claywd : in the WSL section, you wrote "There are limitations within Docker Desktop and how it manages volumes which prevent us from supporting it at this moment.", but AFAIK, kubefirst with WSL is working? This part is not clear to me.

@claywd
Copy link
Contributor Author

claywd commented Jul 10, 2023

@claywd : in the WSL section, you wrote "There are limitations within Docker Desktop and how it manages volumes which prevent us from supporting it at this moment.", but AFAIK, kubefirst with WSL is working? This part is not clear to me.

That was my bad. I meant rancher-desktop

@fharper fharper changed the title feat: Https k3d rancher desktop feat: k3d Rancher Desktop Jul 10, 2023
@fharper fharper merged commit a00e12d into main Jul 10, 2023
1 check passed
@fharper fharper deleted the https_k3d_rancher_desktop branch July 10, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants