Add NoTele param [default: false] #2206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this param set to true, a character will not teleport during pathing, even if the teleport skill is available. This is helpful for chars with low mana management (low max or regen). Without this, if a char runs out of mana too quickly during pathing, they'll either wait for regen (halt, and wait) or will visit town to refill at npc way too often.
esd1
reviewed
Jan 26, 2020
| @@ -118,7 +118,7 @@ var Pather = { | |||
| recursion: true, | |||
|
|
|||
| useTeleport: function () { | |||
| return this.teleport && !me.getState(139) && !me.getState(140) && !me.inTown && ((me.classid === 1 && me.getSkill(54, 1)) || me.getStat(97, 54)); | |||
| return this.teleport && !Config.NoTele && !me.getState(139) && !me.getState(140) && !me.inTown && ((me.classid === 1 && me.getSkill(54, 1)) || me.getStat(97, 54)); | |||
There was a problem hiding this comment.
there is redundancy with Pather.teleport here.
i'd suggest removing this addition and just modify the block a few lines above to something like this:
var Pather = {
teleport: !Config.NoTele,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this param set to true, a character will not teleport during
pathing, even if the teleport skill is available.
This is helpful for chars with low mana management (low max or regen).
Without this, if a char runs out of mana too quickly during pathing,
they'll either wait for regen (halt, and wait) or will visit town to
refill at npc way too often.