Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPHunter improvements #1953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IPHunter improvements #1953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50af27a
IPHunter improvements
Mercoory Oct 13, 2019
71c1b25
Update IPHunter.js
Mercoory Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 45 additions & 15 deletions d2bs/kolbot/libs/bots/IPHunter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,56 @@
/**
* @filename IPHunter.js
* @author kolton
* @author kolton, Mercoory
* @desc search for a "hot" IP and stop if the correct server is found
* @changes (2019.10.06) More beeps when IP found; More often movement when IP found (Anti drop measure); Overhead messages with countdown; Logs to D2BS console
*/

function IPHunter() {
var ip = Number(me.gameserverip.split(".")[3]);
let ip = Number(me.gameserverip.split(".")[3]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Doesn't this work like below? And in case gameserverip for some reason is not there, shouldn't there be an if condition to check it like if (me.gameserverip)?

let ip = +me.gameserverip.split(".")[3];

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me what the + (plus symbol) syntax does and why you think it is more appropriate than Number(...)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just syntactic sugar and can be ignored. But I believe that existence of gameserverip and it having 3 dots should be checked.


if (Config.IPHunter.IPList.indexOf(ip) > -1) {
print("IP found!");
me.maxgametime = 0;
if (Config.IPHunter.IPList.indexOf(ip) > -1) {
D2Bot.printToConsole("IPHunter: IP found! - [" + ip + "] Game is : " + me.gamename + "//" + me.gamepassword, 7);
print("IP found! - [" + ip + "] Game is : " + me.gamename + "//" + me.gamepassword);
me.overhead(":D IP found! - [" + ip + "]");
me.maxgametime = 0;

while (true) {
me.overhead("IP found!");
beep(); // works if windows sounds are enabled
Town.move("waypoint");
Town.move("stash");
delay(60e3);
}
}
for (let i = 12; i > 0; i -= 1) {
me.overhead(":D IP found! - [" + ip + "]" + (i - 1) + " beep left");
beep(); // works if windows sounds are enabled
delay(250);
}

delay(Config.IPHunter.GameLength * 60e3);
while (true) {

return true;
/* // If you want beeping at every movement
for (let i = 12; i != 0; i -= 1) {
me.overhead(":D IP found! - [" + ip + "]" + (i-1) + " beep left");
beep(); // works if windows sounds are enabled
delay(250);
}
*/

me.overhead(":D IP found! - [" + ip + "]");
try {
Town.move("waypoint");
Town.move("stash");
} catch (e) {
// ensure it doesnt leave game by failing to walk due to desyncing.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the error be logged to see what's the problem so it doesn't repeat?

}

for (let i = (12 * 60); i > 0; i -= 1) {
me.overhead(":D IP found! - [" + ip + "] Next movement in: " + i + " sec.");
delay(1000);
}
}
}

for (let i = (Config.IPHunter.GameLength * 60); i > 0; i -= 1) {
me.overhead(":( IP : [" + (ip) + "] NG: " + w + " sec");
delay(1000);
Comment on lines +48 to +50
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get an error on variable "w". Shouln't this be "i" instead?

}

D2Bot.printToConsole("IPHunter: IP was [" + ip + "]", 10);

return true;
}