Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team check function #1860

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Whyy0416
Copy link

@Whyy0416 Whyy0416 commented Aug 6, 2019

Add a new function to make leader wait for other MFHelpers.

@Whyy0416 Whyy0416 mentioned this pull request Aug 7, 2019
TeamCheck: function (phase) {
var MemberCount = 0,
Member = [],
timeOut = 600; //How to put this in character's config ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config.js holds the default Config variables that are overridden in the character config files. You can put this in both those places, and the one in Config.js will be used as a default if the character config doesn't have it

Copy link

@jmichelsen jmichelsen Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like Config.TeamCheck.Timeout or whatever

@@ -233,6 +233,8 @@ var Attack = {

if (Config.MFLeader) {
Pather.makePortal();
Pather.TeamCheck(1); //add by WhyY0416

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your changes are annotated in git, so your name is already on these lines as far as git is concerned. You don't need these comments with your name :)

@DrShunk
Copy link

DrShunk commented Jan 25, 2020

I really like this, but is there anyway I can get my MFHelper to forcefinish if the Leader is done?

My Barb doesn't have teleport & takes forever wandering around Pit to check the map is cleared. I just want him to drop everything and move to the next area if my Leader (Sorc) is done.

My leader Sorc was spamming "Finish Check" and my Barb just continued to wander around. In comparison, my second Sorc was in town waiting for next area after responding to the Finish Check.

Again, this runs wonderful if everyone has Enigma.

@mf022
Copy link
Contributor

mf022 commented Feb 23, 2020

MFHelper leaving the area if leader isn't there was added in blizzhackers/kolbot#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants