Skip to content

Commit

Permalink
MAINT: PR 54 revisions
Browse files Browse the repository at this point in the history
* compile using genuine `bool` type instead of an alias

* this seems to succeed at build stage, but a few tests do fail
at the moment

[skip ci]
  • Loading branch information
tylerjereddy committed Oct 26, 2022
1 parent 2b961fe commit d5c85c6
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions include/traits.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ VIEW_DATA_DIMS(8, T ********)
// the first string identifier is the "canonical name" (i.e. what gets encoded)
// and the remaining string entries are used to generate aliases
//
typedef uint8_t bool_t;

VIEW_DATA_TYPE(int8_t, Int8, "int8", "signed_char")
VIEW_DATA_TYPE(int16_t, Int16, "int16", "short")
VIEW_DATA_TYPE(int32_t, Int32, "int32", "int")
Expand All @@ -87,8 +85,7 @@ VIEW_DATA_TYPE(uint32_t, Uint32, "uint32", "unsigned", "unsigned_int")
VIEW_DATA_TYPE(uint64_t, Uint64, "uint64", "unsigned_long")
VIEW_DATA_TYPE(float, Float32, "float32", "float")
VIEW_DATA_TYPE(double, Float64, "float64", "double")
// TODO: real bool type instead of alias
VIEW_DATA_TYPE(bool_t, Bool, "bool", "bool_")
VIEW_DATA_TYPE(bool, Bool, "bool", "bool_")

//----------------------------------------------------------------------------//
// <data-type> <enum> <string identifiers>
Expand Down

0 comments on commit d5c85c6

Please sign in to comment.