Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In team labs logos: reordered by alphabetical order & resized to unify height #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbigot
Copy link
Member

@jbigot jbigot commented Jul 9, 2024

No description provided.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you build it locally? Could you take a screenshot and post it in the description?

@jbigot
Copy link
Member Author

jbigot commented Jul 9, 2024

sure can:
image

@jbigot
Copy link
Member Author

jbigot commented Jul 9, 2024

I tried to target a somewhat similar text size, we can play with the relative sizes. Maybe Sandia is still a bit small in comparison

@dalg24
Copy link
Member

dalg24 commented Jul 9, 2024

Looks good. Can you comment about the new logos being added? Is that not something that can be handled just by specifying the size of the logo that are already present? If not do we want to keep both versions?

@jbigot
Copy link
Member Author

jbigot commented Jul 9, 2024

I've just auto-cropped the white around the logos to add a margin in CSS of the same size for each logo

@jbigot jbigot force-pushed the cea_contributors branch from 78b9feb to 3cbba37 Compare July 9, 2024 15:37
@jbigot jbigot force-pushed the cea_contributors branch from 3cbba37 to 93e9dc1 Compare July 9, 2024 15:39
@jbigot
Copy link
Member Author

jbigot commented Jul 9, 2024

LANL & CSCS logos were not used elsewhere I removed them, SNL logo is used in acknowledgements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants