Improve batched serial trsv #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasahi-hpc
force-pushed
the
improve-batched-serial-trsv
branch
from
f16925c to
392745c
Compare
brian-kelley
reviewed
Dec 9, 2024
added 8 commits
December 10, 2024 13:10
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
yasahi-hpc
force-pushed
the
improve-batched-serial-trsv
branch
from
07ad22e to
78a2066
Compare
|
@brian-kelley |
brian-kelley
approved these changes
Dec 10, 2024
brian-kelley
added
AT: PRE-TEST INSPECTED
lucbv
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at improving the implementation and testing of serial Trsv.
Implnamespace.Upper/Lower,Non-Trans/Trans/ConjTrans, andUnit/Non-UnitKokkos::ViewUpper/Lower,Non-Trans/Trans/ConjTrans, andUnit/Non-UnitAs a TO DO task, we need to add a ConjTrans implementation of blocked version which requires a little more investigation