Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RISC-V architectures #603

Closed
wants to merge 8 commits into from
Closed

Add RISC-V architectures #603

wants to merge 8 commits into from
+20 −0

Conversation

diehlpk
Copy link

@diehlpk diehlpk commented Nov 13, 2024

Add the two recently added RISC-V architectures to Kokkos.

@JBludau
Copy link
Contributor

JBludau commented Nov 13, 2024 •
edited
Loading

could you hold this until #602 is merged, rebase, and then add it in the corresponding table?

@diehlpk
Copy link
Author

diehlpk commented Nov 14, 2024

Yes, I can.

@JBludau
Copy link
Contributor

JBludau commented Nov 25, 2024

@diehlpk #602 is merged now, please go ahead. Thanks for waiting

@diehlpk
Copy link
Author

diehlpk commented Dec 2, 2024

@JBludau I resolved the merge conflict but still need to wait for the merge conflict.

dalg24
dalg24 reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add a 4th column with "Notes" saying since what release these are available

docs/source/keywords.rst Outdated Show resolved Hide resolved
docs/source/keywords.rst Outdated Show resolved Hide resolved
dalg24
dalg24 reviewed Dec 2, 2024
View reviewed changes
docs/source/keywords.rst Outdated Show resolved Hide resolved
docs/source/keywords.rst Outdated Show resolved Hide resolved
docs/source/keywords.rst Outdated Show resolved Hide resolved
docs/source/keywords.rst Outdated Show resolved Hide resolved
docs/source/keywords.rst Outdated Show resolved Hide resolved
docs/source/keywords.rst Outdated Show resolved Hide resolved
dalg24
dalg24 reviewed Dec 2, 2024
View reviewed changes
docs/source/keywords.rst Outdated Show resolved Hide resolved
dalg24
dalg24 reviewed Dec 2, 2024
View reviewed changes
docs/source/keywords.rst Outdated Show resolved Hide resolved
dalg24
dalg24 reviewed Dec 2, 2024
View reviewed changes
docs/source/keywords.rst Outdated Show resolved Hide resolved
docs/source/keywords.rst Outdated Show resolved Hide resolved
@dalg24 dalg24 mentioned this pull request Dec 2, 2024
Merged
@dalg24
Copy link
Member

dalg24 commented Dec 2, 2024

Closing in favor of #608
Wasted enough time trying to fiddle with it on the online editor

@dalg24 dalg24 closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBludau JBludau JBludau left review comments

@dalg24 dalg24 dalg24 left review comments

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diehlpk @JBludau @dalg24 @masterleinad