Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#120: API-core-stl_compat-pair from md to rst #308

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

#120: API-core-stl_compat-pair from md to rst #308

wants to merge 8 commits into from

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Feb 21, 2023 •
edited
Loading

THIS PR:

  • API/core/stl_compat/pair transition from .md to .rst
  • uses cppkokkos
  • rebased on latest main
  • screenshots

issue:

  • weird color for line function 62
    image
    Here is the warning
before (.md) after (.rst)
image image
image image

@antoinemeyer5 antoinemeyer5 mentioned this pull request Feb 21, 2023
Closed
fnrizzi
fnrizzi requested changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@fnrizzi fnrizzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoinemeyer5

  1. please remote the synopsis
  2. please document the class properly using cppkokkos, right now it is a mix of blocks and things. Look at this: #120: API-core-utilities-complex from md to rst #312 , follow a similar format

@antoinemeyer5 antoinemeyer5 requested a review from fnrizzi March 2, 2023 09:42
@fnrizzi fnrizzi marked this pull request as draft March 2, 2023 13:53
@antoinemeyer5
Copy link
Collaborator Author

antoinemeyer5 commented Jun 8, 2023 •
edited
Loading

I always get error messages.

Here are 3 examples that work and the result we'd like to have that doesn't:

image

What should I do now @fnrizzi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmm0 nmm0 Awaiting requested review from nmm0

@ajpowelsnl ajpowelsnl Awaiting requested review from ajpowelsnl

@fnrizzi fnrizzi Awaiting requested review from fnrizzi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinemeyer5 @fnrizzi