fix: update readme and fix load config (#5)

* fix function * Fix styling * add version Co-authored-by: sangvictim <[email protected]>
kodepandai · Oct 7, 2021 · 3d1e5e2 · 3d1e5e2
1 parent 2fb166e
commit 3d1e5e2
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 27 deletions.
diff --git a/README-ID.md b/README-ID.md
@@ -32,14 +32,19 @@ Ini adalah konten dari file config yang telah dipublish:
 
 ```php
 return [
+    'API_KEY' => env('RAJAONGKIR_KEY', 'somerandomstring'),
+    'ACCOUNT_TYPE' => env('RAJAONGKIR_TYPE', 'starter')
 ];
 ```
 
 ## Penggunaan
 
 ```php
-$laravel-rajaongkir = new Kodepintar\LaravelRajaongkir();
-echo $laravel-rajaongkir->echoPhrase('Hello, Kodepintar!');
+use Kodepintar\LaravelRajaongkir\LaravelRajaongkir as Ongkir;
+
+$data = new Ongkir();
+$data = $data->getProvince();
+return $data;
 ```
 
 ## Kredit

diff --git a/README.md b/README.md
@@ -31,14 +31,19 @@ This is the contents of the published config file:
 
 ```php
 return [
+    'API_KEY' => env('RAJAONGKIR_KEY', 'somerandomstring'),
+    'ACCOUNT_TYPE' => env('RAJAONGKIR_TYPE', 'starter')
 ];
 ```
 
 ## Usage
 
 ```php
-$laravel-rajaongkir = new Kodepintar\LaravelRajaongkir();
-echo $laravel-rajaongkir->echoPhrase('Hello, Kodepintar!');
+use Kodepintar\LaravelRajaongkir\LaravelRajaongkir as Ongkir;
+
+$data = new Ongkir();
+$data = $data->getProvince();
+return $data;
 ```
 
 ## Credits

diff --git a/composer.json b/composer.json
@@ -1,6 +1,7 @@
 {
     "name": "kodepintar/laravel-rajaongkir",
     "description": "This is my package laravel-rajaongkir",
+    "version": "1.0",
     "keywords": [
         "kodepintar",
         "laravel",

diff --git a/resources/views/.gitkeep b/resources/views/.gitkeep
diff --git a/src/Commands/LaravelRajaongkirCommand.php b/src/Commands/LaravelRajaongkirCommand.php
diff --git a/src/LaravelRajaongkir.php b/src/LaravelRajaongkir.php
@@ -2,12 +2,11 @@
 
 namespace Kodepintar\LaravelRajaongkir;
 
-use Illuminate\Http\Client\Response;
 use Illuminate\Support\Facades\Http;
 
 class LaravelRajaongkir
 {
-    public const BASE_URL = [
+    protected $BASE_URL = [
         'starter' => 'https://api.rajaongkir.com/starter',
         'basic' => 'https://api.rajaongkir.com/basic',
         'pro' => 'https://pro.rajaongkir.com/api',
@@ -17,19 +16,19 @@ class LaravelRajaongkir
 
     public function __construct()
     {
-        $accountType = config('rajaongkir.ACCOUNT_TYPE');
+        $accountType = config('rajaongkir.ACCOUNT_TYPE', env('RAJAONGKIR_TYPE'));
 
-        $this->url = self::BASE_URL[$accountType];
+        $this->url = $this->BASE_URL[$accountType];
 
         return $this;
     }
 
-    protected function apiCall(string $urlPath, array $payload = [], string $method = 'GET'): Response
+    protected function apiCall(string $urlPath, array $payload = [], string $method = 'GET')
     {
         $url = $this->url . '/' . ltrim($urlPath, '/');
 
         return Http::withHeaders([
-            'key' => config('rajangkir.API_KEY'),
+            'key' => config('rajaongkir.API_KEY', env('RAJAONGKIR_KEY')),
             'content-type' => 'application/x-www-form-urlencoded',
         ])->{strtolower($method)}($url, $payload);
     }