Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizations): account sidenav update for MMOs TASK-977 #5234

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Nov 6, 2024

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Handle MMO and non-MMO orgs, as well as org roles, in the account sidebar.

👀 Preview steps

Based on figma designs here

Requires MMO feature flag

  1. Create a user and check to ensure account sidenav remains unchanged on Stripe-enabled and disabled environments. The should be no changes for users who are not members of an MMO.
  2. Make user's org an MMO, with them as an owner, and check the sidenav with Stripe enabled and disabled against the Figma designs for org owners.
  3. Create another user and add them to the MMO (make sure to delete their personal org). Make them an admin and check against the figma designs as above.
  4. Make second user a member (uncheck "admin" on their org user object in django admin) and check against the figma designs as above.
  5. Toggle the use_team_label option in constance and see organization/team label change accordingly in sidenav.

Copy link

@jamesrkiger jamesrkiger self-assigned this Nov 6, 2024
@jamesrkiger jamesrkiger changed the title feat(organizations): Account sidenav update for MMOs TASK-977 feat(organizations): account sidenav update for MMOs TASK-977 Nov 6, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noob question: Don't you also need to push the files generated by the script? Or didn't you need to run the generator for this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauloamorimbr Nope, not necessary since the script gets run on install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants