Properly flatten select_one_from_file #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm
force-pushed
the
properly-flatten-select_one_from_file
branch
from
dc57cf4
to
4e50177
Compare
jnm
changed the title
(test currently failing)
…to `select_one_from_file file.csv` instead of having `select_one_from_file` in the `type` column and `file.csv` in a nonstandard `file` column. Fixes a problem introduced in #314
jnm
force-pushed
the
properly-flatten-select_one_from_file
branch
from
4e50177
to
0831cf7
Compare
duvld
approved these changes
Jan 31, 2024
jnm
added a commit
to kobotoolbox/kpi
that referenced
this pull request
Jun 18, 2024
`file` columns in `select_one_from_file` and `select_multiple_from_file`
rows. This was causing a `KeyError` when the asset content predated
Flattening of `{"type": "select_one_from_file", "file": "choices.csv"}`
(and equivalent `select_multiple_from_file` structures) to the
XLSForm-standard `{"type": "select_one_from_file choices.csv"}` is
handled by kobotoolbox/formpack#318 and kobotoolbox/formpack#319.
jnm
added a commit
to kobotoolbox/kpi
that referenced
this pull request
Jun 18, 2024
`file` columns in `select_one_from_file` and `select_multiple_from_file`
rows. This was causing a `KeyError` when the asset content predated
Flattening of `{"type": "select_one_from_file", "file": "choices.csv"}`
(and equivalent `select_multiple_from_file` structures) to the
XLSForm-standard `{"type": "select_one_from_file choices.csv"}` is
handled by kobotoolbox/formpack#318 and kobotoolbox/formpack#319.
jnm
added a commit
to kobotoolbox/kpi
that referenced
this pull request
Jun 18, 2024
`file` columns in `select_one_from_file` and `select_multiple_from_file` rows. This was causing a `KeyError` when the asset content predated #4403 and kobotoolbox/formpack#314. Flattening of `{"type": "select_one_from_file", "file": "choices.csv"}` (and equivalent `select_multiple_from_file` structures) to the XLSForm-standard `{"type": "select_one_from_file choices.csv"}` is handled by kobotoolbox/formpack#318 and kobotoolbox/formpack#319.
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to
select_one_from_file file.csvinstead of havingselect_one_from_filein thetypecolumn andfile.csvin a nonstandardfilecolumn.Fixes a problem introduced in #314
Reminder: update
formbuilder-miscbranch in KPI to require the new formpack commit hash once this is merged