Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deepcopying faster #217

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

@coveralls
Copy link

coveralls commented May 2, 2020

Coverage Status

Coverage increased (+0.05%) to 84.0% when pulling 2a6657f on mlazowik:msgpack-copy into 8628d7e on kobotoolbox:master.

@dorey
Copy link
Contributor

dorey commented May 2, 2020

Much of the performance issues with deepcopy from the original formpack code could be lessened by using immutable data structures throughout. msgpack is interesting though

@mlazowik
Copy link
Author

mlazowik commented May 2, 2020

Yeah, this is definitely not the proper long-term solution. I'm dealing with a time sensitive situation, so while I'll be adding msgpack to our fork I still wanted to see if it's useful upstream (here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants