Remote pack #125
Open
Remote pack #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directory for testing formpack reports
to the methods that use them because they are not reused very much, and hide the transformation that goes into building the Fields, Sections, and Versions * added a `src` parameter to many of the fields / sections to facilitate debugging the content that was used to create the python objects in the form `version.Version` * added a `pull.py` script to expose options to the CLI * `select_one_external` is now the preferred alias throughout the code (underscores instead of spaces) * added comment about xform_tools.normalize_data_type (obsolete) with `replace_aliases`, which is run on the content before the version is initialized.
with a method "run" that receives the formpack object
* strip "content" field from asset.json (redundant with versions json stored separately) * use `date_deployed` rather than `date` (for now)
* at first, this will be used in just tests; eventually it could be a way to store the submissions that fed to the formpack via generators.
translated_item * passing TranslatedItem() object instead of dict when fields and sections are created * added assertions which, when uncommented, should not fail (but don't want to risk AssertionErrors in production)
TranslatedItem
(pack.submissions will be used in future tests)
|
Was a nice attempt. But we didn't go this direction with formpack. |
|
I used this not so long ago :) Thanks for leaving the branch intact. It might be something we can come back to as time permits. |
|
Glad to hear it was used. Maybe we should keep it open with a tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review: Is there anything else we want to add into this before merging?
pull.pycould have a--autoreportsflagid_stringswill overlap