Circom 0.5 binary formats support #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobigurk
requested changes
Jun 19, 2020
phase2/src/circom_circuit.rs
Outdated
| q[i] = reader.read_u64::<LittleEndian>()?; | ||
| } | ||
|
|
||
| if q != [ |
There was a problem hiding this comment.
This is the prime field of Fr in the bn254.
This field is in the format because the format accepts any curv.
There was a problem hiding this comment.
Nice, thanks. Can you add a comment about it?
|
|
||
|
|
||
|
|
||
| fn circuit_from_r1cs_read_header<E: Engine, R:Read>(circuit : &mut CircomCircuit<E>, reader: &mut R) -> std::io::Result<()> { |
There was a problem hiding this comment.
Can we add a link to the format?
…in/verify_contribution
|
I see that cargo fmt affect many parts of the project. Am I doing some thing wrong? If this affects all the project then it's better to run it a project level? |
OK, my bad. I'll take care of that later :) Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for .r1cs file and .wtns file.
This are the default outputs in circom 0.5
Those files are in binary and allow to work wit bigger circuits.