Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

update npm versions #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update npm versions #255

wants to merge 2 commits into from

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Feb 19, 2021

Update packages that are out of date.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 19, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vaikas after the PR has been reviewed.
You can assign the PR to them by writing /assign @vaikas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 19, 2021
"devDependencies": {
"autoprefixer": "^9.8.6",
"js-yaml": "^3.14.0",
"lodash": ">=4.17.19",
"mixin-deep": ">=1.3.2",
"postcss-cli": "^6.1.3",
"postcss-cli": "^8.3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaikas did you tested the website locally and there is not problems with new version?

I asked because the bump is a major semantic change which usually comes with braking APIs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular tool is only used for processing CSS before shipping, and should be okay.

Base automatically changed from master to main March 8, 2021 17:38
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was somehow confused by the master/main transition. Hoping a comment will kick things off the right way.

"devDependencies": {
"autoprefixer": "^9.8.6",
"js-yaml": "^3.14.0",
"lodash": ">=4.17.19",
"mixin-deep": ">=1.3.2",
"postcss-cli": "^6.1.3",
"postcss-cli": "^8.3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular tool is only used for processing CSS before shipping, and should be okay.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2021
@knative-prow-robot
Copy link
Contributor

@vaikas: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Indicates the PR's author has signed the CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants