This repository has been archived by the owner on May 15, 2023. It is now read-only.
Convert (nearly) all usages of MelonLogger to MelonLogger.Instance #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NativePatchUtils.cs could not be converted nicely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted MelonLogger usage to MelonLogger.Instance in all places it could be used, as using MelonLogger causes potential issues when the GetMelonFromStackTrace function is called.
This issue has been corrected with TotallyWholesome and emmVRC by emmVRC converting their usage of MelonLogger, it appears that any mods that are using the non Instance loggers can potential cause issues if the stack trace gets complex enough. The actual issue lies within Mono itself, and attempts to work around it haven't been successful, converting to Instance appears to be the simplest way to get everything working.
The issues usually manifest as either the game hanging, or the game fully crashing and resulting in a dump, both results show different parts of the Mono stack trace unwinder failing.
I tried to match formatting where applicable.
I've also added the reference to 0Harmony.dll to the Directory.Build.Props as it was missing.