Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forward Email for smtp and bounce support #2016

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

shaunwarman
Copy link
Contributor

@shaunwarman shaunwarman commented Aug 27, 2024

This PR adds Forward Email as an smtp provider as well as includes bounce support.

Relevant Forward Email documentation:

NOTE: I did not update all of the translations. Do you have a set process or recommendation on how to update those? Translation service or some LLM?

@shaunwarman shaunwarman changed the title feat: add forwardemail for smtp and bounce support feat: add Forward Email for smtp and bounce support Aug 27, 2024
@shaunwarman shaunwarman changed the title feat: add Forward Email for smtp and bounce support Add Forward Email for smtp and bounce support Aug 27, 2024
@knadh knadh self-assigned this Aug 27, 2024
@knadh
Copy link
Owner

knadh commented Aug 27, 2024

Thanks @shaunwarman. I've a local LLM script that translates missing strings. Will run that once this is merged. Will review this PR once v4.0.0 is done (as it has a large number of breaking changes).

@shaunwarman
Copy link
Contributor Author

Ack, sounds good!

@titanism
Copy link

titanism commented Nov 4, 2024

@knadh Any update here? We put a lot of effort in here to make it compatible with ListMonk!

@titanism
Copy link

titanism commented Nov 5, 2024

Lots of high demand here https://github.com/orgs/forwardemail/discussions/255 + from existing users

@knadh
Copy link
Owner

knadh commented Nov 5, 2024

@titanism v4.x.x was released just a few days ago. I'll look into this PR in the next few days. In the meanwhile, could you please fix the merge conflicts that seem to have come up since the last release.

@shaunwarman
Copy link
Contributor Author

Thanks @knadh ! Just rebased. Let me know if any extra testing / screenshots needed here.

@titanism
Copy link

titanism commented Nov 9, 2024

@knadh would love to get this merged so our users can easily use ListMonk!

@knadh
Copy link
Owner

knadh commented Nov 10, 2024

Made a few minor tweaks and added missing DB migration and language scripts. Refactored the settings to be stored in a single JSON key like Postmark which is cleaner, instead of two separate fields like SES etc (legacy).

Please test this and once you confirm, we're good to merge.

@shaunwarman
Copy link
Contributor Author

shaunwarman commented Nov 10, 2024

Awesome, thanks for doing that @knadh - things look great on my side!

Screenshot 2024-11-10 at 9 54 49 AM Screenshot 2024-11-10 at 10 09 28 AM Screenshot 2024-11-10 at 10 17 06 AM

@knadh knadh merged commit cb8b54f into knadh:master Nov 10, 2024
@knadh
Copy link
Owner

knadh commented Nov 10, 2024

I'm working on v4.1.0 with a couple of bug fixes from the last release. Will release in the next 1-2 days.

@shaunwarman
Copy link
Contributor Author

Awesome, here if you need us!

@titanism
Copy link

@knadh amazing work, can you ping us here once v4.1.0 is available? we will advertise it on our site!

@MaximilianKohler
Copy link
Contributor

It's available.

@titanism
Copy link

any chance the demo at listmonk.app could be updated to latest? or is this part of a CI somehow? @MaximilianKohler - it seems outdated cc @knadh 🙏

@knadh
Copy link
Owner

knadh commented Nov 15, 2024

Demo's updated to the latest version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants