Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clean bpf_map twice in test #856

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:
Because cleanup bpf map in loader.Stop(). so there is no need to execute bpf.cleanup again
Which issue(s) this PR fixes:
Fixes #844

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: LiZhenCheng9527 <[email protected]>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (62b5061) to head (8105676).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
pkg/status/status_server.go 33.18% <100.00%> (ø)
pkg/utils/test/bpf_map.go 42.10% <ø> (-1.49%) ⬇️
pkg/bpf/bpf.go 41.07% <0.00%> (-0.75%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bcc1f...8105676. Read the comment docs.

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 89adfd1 into kmesh-net:main Sep 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error from test unmount /mnt/kmesh_cgroup2 error: no such file or directory
3 participants