support dump workload bpf map #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
Okabe-Rintarou-0
force-pushed
the
feat/workload_bpf
branch
from
daaec4a
to
4277510
Compare
|
since we have some problems in ads bpf map deserialization, i first implemented the workload bpf map. |
Signed-off-by: [email protected] <[email protected]>
Okabe-Rintarou-0
force-pushed
the
feat/workload_bpf
branch
from
4277510
to
1590ec6
Compare
Signed-off-by: [email protected] <[email protected]>
Okabe-Rintarou-0
force-pushed
the
feat/workload_bpf
branch
from
614f7c3
to
4690cb6
Compare
|
WIP, exists some erros |
Signed-off-by: [email protected] <[email protected]>
|
Great. let me try |
YaoZengzeng
reviewed
Sep 14, 2024
pkg/status/status_server.go
Outdated
| func (s *Server) bpfAdsMaps(w http.ResponseWriter, r *http.Request) { | ||
| client := s.xdsClient | ||
| if client == nil || client.AdsController == nil { | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| fmt.Fprintf(w, "\t%s\n", "invalid ClientMode") | ||
| fmt.Fprint(w, invalidModeErrMessage) |
There was a problem hiding this comment.
We could also wrap it into a function like checkAdsMode()
YaoZengzeng
reviewed
Sep 14, 2024
pkg/status/status_server.go
Outdated
| @@ -257,7 +309,7 @@ func (s *Server) configDumpAds(w http.ResponseWriter, r *http.Request) { | |||
| client := s.xdsClient | |||
| if client == nil || client.AdsController == nil { | |||
| w.WriteHeader(http.StatusBadRequest) | |||
| fmt.Fprintf(w, "\t%s\n", "invalid ClientMode") | |||
| fmt.Fprint(w, invalidModeErrMessage) | |||
hzxuzhonghu
reviewed
Sep 14, 2024
|
|
||
| func (c *Cache) WorkloadPolicyLookupAll() []WorkloadPolicy_value { | ||
| log.Debugf("WorkloadPolicyLookupAll") | ||
| return LookupAll[WorkloadPolicy_key, WorkloadPolicy_value](c.bpfMap.MapOfWlPolicy) |
There was a problem hiding this comment.
Nit: WorkloadPolicy_key WorkloadPolicy_value should be camel format
| @@ -0,0 +1,19 @@ | |||
| package bpfcache | |||
| "github.com/cilium/ebpf" | ||
| ) | ||
|
|
||
| func LookupAll[K any, V any](bpfMap *ebpf.Map) []V { |
pkg/status/status_server.go
Outdated
| @@ -46,6 +47,7 @@ const ( | |||
| patternHelp = "/help" | |||
| patternOptions = "/options" | |||
| patternBpfAdsMaps = "/debug/bpf/ads" | |||
| patternBpfWorkloadMaps = "/debug/bpf/workload" | |||
There was a problem hiding this comment.
how about /debug/config_dump/bpf/workload
and /debug/config_dump/bpf/ads
Signed-off-by: [email protected] <[email protected]>
Okabe-Rintarou-0
force-pushed
the
feat/workload_bpf
branch
from
17821b5
to
30126b4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: