-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make default logger only print to stderr not file #847
Conversation
Signed-off-by: Zhonghu Xu <[email protected]>
Fix #835 |
Codecov ReportAttention: Patch coverage is
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pkg/controller/telemetry/utils.go
Outdated
@@ -30,7 +30,7 @@ import ( | |||
) | |||
|
|||
var ( | |||
log = logger.NewLoggerField("pkg/telemetry") | |||
log = logger.NewLoggerScope("pkg/telemetry") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
log = logger.NewLoggerScope("pkg/telemetry") | |
log = logger.NewLoggerScope("telemetry") |
or controller/telemetry
pkg/auth/rbac.go
Outdated
@@ -47,7 +47,7 @@ const ( | |||
) | |||
|
|||
var ( | |||
log = logger.NewLoggerField("pkg/auth") | |||
log = logger.NewLoggerScope("pkg/auth") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log = logger.NewLoggerScope("pkg/auth") | |
log = logger.NewLoggerScope("auth") |
pkg
as prefix doens't seem to make sense?
pkg/bpf/bpf.go
Outdated
@@ -39,7 +39,7 @@ import ( | |||
) | |||
|
|||
var ( | |||
log = logger.NewLoggerField("pkg/bpf") | |||
log = logger.NewLoggerScope("pkg/bpf") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log = logger.NewLoggerScope("pkg/bpf") | |
log = logger.NewLoggerScope("bpf") |
ditto
Signed-off-by: Zhonghu Xu <[email protected]>
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: