Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible panic in loadKmeshSendmsgObjects #804

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

lec-bit
Copy link
Contributor

@lec-bit lec-bit commented Aug 31, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix possible panic in loadKmeshSendmsgObjects
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Aug 31, 2024
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This happened when i deleted the sys/fs/bpf dir, but unfortuanately the kmesh_version map still there, not sure why.

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.07%. Comparing base (9db2d28) to head (c5b0842).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf_kmesh_workload.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/bpf/bpf_kmesh_workload.go 60.45% <0.00%> (-0.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1136f54...c5b0842. Read the comment docs.

@LiZhenCheng9527 LiZhenCheng9527 added this pull request to the merge queue Aug 31, 2024
Merged via the queue into kmesh-net:main with commit e2b8d2e Aug 31, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants