Fix UT failure #1006
Fix UT failure #1006
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Muyang Tian <[email protected]>
| @@ -30,6 +30,7 @@ import ( | |||
| type CleanupFn func() | |||
|
|
|||
| func InitBpfMap(t *testing.T, config options.BpfConfig) (CleanupFn, *bpf.BpfLoader) { | |||
| bpf.CleanupBpfMap() | |||
| @@ -73,10 +72,6 @@ func (sc *BpfAds) Start() error { | |||
| return fmt.Errorf("deserial_init failed:%v", ret) | |||
| } | |||
|
|
|||
| if err := maglev.InitMaglevMap(); err != nil { | |||
There was a problem hiding this comment.
I think this is needed by maglev, without init it would fail to work
| @@ -73,10 +72,6 @@ func (sc *BpfAds) Start() error { | |||
| return fmt.Errorf("deserial_init failed:%v", ret) | |||
| } | |||
|
|
|||
| if err := maglev.InitMaglevMap(); err != nil { | |||
There was a problem hiding this comment.
Why remove maglev.InitMaglevMap()
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix UT failure
Which issue(s) this PR fixes:
Fixes #1004
Special notes for your reviewer:
Does this PR introduce a user-facing change?: