-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protonvpn wireguard config downloader #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 69.66% 69.66%
=======================================
Files 30 30
Lines 946 946
Branches 93 93
=======================================
Hits 659 659
Misses 267 267
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you it's great and functional but I'd like a bit more details as comments.
That notion of port is unclear to me. What would one care about it? What are the consequences of picking one or not?
protonvpn-wireguard-config-downloader/src/protonvpn_wireguard_config_downloader/__about__.py
Outdated
Show resolved
Hide resolved
protonvpn-wireguard-config-downloader/src/protonvpn_wireguard_config_downloader/settings.py
Show resolved
Hide resolved
protonvpn-wireguard-config-downloader/src/protonvpn_wireguard_config_downloader/protonvpn.py
Show resolved
Hide resolved
for server in session.server_list.logicals | ||
if server.enabled and server.tier <= session.server_list.user_tier | ||
) | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a comment here about how data is organized in their API so it's easier to maintain this in a year :)
I also recall that the UI mentions an expiration date. Are those ones expiring at some point? When?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, regarding this. I can't see a parameter for configuring the timeline. On the web browser, the credentials don't show either. I checked out their desktop code and there wasn't expiration set. It was simply saving the files to disk and updating them whenever the connection settings changed. In their case, there was only one configuration file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing I noticed was that the web client used a serial number for the configuration files but I didn't see similar code used in other clients. Also, the clients config when created on the web expires when their plan is inactive. I assume the same applies for the configs generated by this script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make a different PR depending on what I find out about this.
Our wireguard configuration from the |
OK, please add it in the README |
Changes