Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stdin default from create-countries subcommand #45

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

elfkuzco
Copy link
Collaborator

Changes

  • Remove stdin default from create-countries subcommand.

This resolves #44

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (0c088e1) to head (93da9ba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   69.66%   69.66%           
=======================================
  Files          30       30           
  Lines         946      946           
  Branches       93       93           
=======================================
  Hits          659      659           
  Misses        267      267           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elfkuzco
Copy link
Collaborator Author

Um, should I do this for the create-worker sub-command too? Just remembered it reads the public key from stdin too.

@elfkuzco elfkuzco requested a review from rgaudin August 24, 2024 01:29
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfkuzco elfkuzco merged commit b522855 into main Aug 24, 2024
4 checks passed
@elfkuzco elfkuzco deleted the fix-create-countries-cmd branch August 24, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-countries should stop without input
3 participants