Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subcommand for updating mirror detail #43

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

elfkuzco
Copy link
Collaborator

Changes

  • add subcommand for updating a mirror's details
    • update the list of other countries for a mirror using --regions. This sets the other_countries using all the countries found in the provided regions in addition to the countries in the default region of the mirror.
    • update the default region for a mirror using --region
    • update the default country of a mirror using --country

These changes (in additon to #42 ) lay the foundation for #39 as the initial db schema didn't have regions or country information in mirrors

@elfkuzco elfkuzco requested a review from rgaudin August 23, 2024 13:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 28.76712% with 52 lines in your changes missing coverage. Please review.

Project coverage is 69.66%. Comparing base (656e88d) to head (ae7183c).

Files Patch % Lines
backend/src/mirrors_qa_backend/entrypoint.py 0.00% 33 Missing ⚠️
backend/src/mirrors_qa_backend/cli/mirrors.py 0.00% 13 Missing ⚠️
backend/src/mirrors_qa_backend/db/mirrors.py 77.77% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   72.75%   69.66%   -3.10%     
==========================================
  Files          30       30              
  Lines         881      946      +65     
  Branches       81       93      +12     
==========================================
+ Hits          641      659      +18     
- Misses        222      267      +45     
- Partials       18       20       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfkuzco elfkuzco merged commit 0c088e1 into main Aug 23, 2024
4 checks passed
@elfkuzco elfkuzco deleted the mirror-detail-subcommand branch August 23, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants