-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Windows CI. #695
Add a Windows CI. #695
Conversation
Compilation of kiwix-tools is broken on Windows. But let's setup the CI to validate the PR.
I though we have Windows CD using win2019 to ensure binaries run on older versions of Windows. But here CI is only win2022... which would be a pb. What are version of windows used for CI, for CD? And why? |
win2019 vs win2022 is mainly about visual studio version. I suppose we should use win2022 everywhere. But it seems not important as you have added a libzim CI using win2022 which compile with deps build on win2019... |
@mgautierfr Then why relying on win2019 at all? We should use only 2022 version everywhere. |
Where ? |
b48daf4
to
0ba913f
Compare
Packages workflow because kiwix-tools cannot found the docopt dependencies. The only difference with zim-tools is that docopt is a new dependency here. Maybe there is some kind of cache somewhere ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly looked at the C++ code. Note that I didn't check that the usage strings were updated accurately.
New version splits commit and small fixes of previous review are already squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase-fixup-and-merge before @kelson42 merges without fixing-up :)
We don't setup signal handler on Windows, so we can replace `volatil sig_atomic_t` by simple `bool`.
@mgautierfr All the deb packages pass on |
Yes, see this comment : #695 (comment) |
@mgautierfr @veloman-yunkan For an unknow reason xmake seems to be missing https://github.com/kiwix/kiwix-tools/actions/runs/10634049570/job/29480511704#step:10:507 @tusharpm Maybe you understand better what is missing here? |
Try adding |
So, now it passes and I'm going to merge. |
Compilation of kiwix-tools is broken on Windows.
But let's setup the CI to validate the PR (to be fixed)