Skip to content

Commit

Permalink
Removed display of brief article description in popovers #1276 (#1278)
Browse files Browse the repository at this point in the history
Signe off by @THEBOSS0369
  • Loading branch information
THEBOSS0369 authored Oct 12, 2024
1 parent 026647f commit 7484e57
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion www/js/lib/popovers.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,20 @@ function getArticleLede (href, baseUrl, articleDocument, archive) {

// Helper function to clean up the lede content
function cleanUpLedeContent (node) {
// Define an array of exclusion filters
// (note `.exclude-this-class` is a dummy class used as an example for any future exclusion filters)
const exclusionFilters = ['#pcs-edit-section-title-description', '.exclude-this-class'];
// Construct the `:not()` CSS exclusion selector list
const notSelector = exclusionFilters.map(filter => `:not(${filter})`).join('');

// Remove all standalone style elements from the given DOM node, because their content is shown by innerText and textContent
const styleElements = Array.from(node.querySelectorAll('style'));
styleElements.forEach(style => {
style.parentNode.removeChild(style);
});
const paragraphs = Array.from(node.querySelectorAll('p'));
// Apply this style-based exclusion filter to remove unwanted paragraphs in the popover
const paragraphs = Array.from(node.querySelectorAll(`p${notSelector}`));

// Filter out empty paragraphs or those with less than 50 characters
const parasWithContent = paragraphs.filter(para => {
// DEV: Note that innerText is not supported in Firefox OS, so we need to use textContent as a fallback
Expand Down

0 comments on commit 7484e57

Please sign in to comment.