Correctly include lib64 library on manylinux archives

[mgautierfr]

Manylinux build are based on Redhat and libs are put in /lib64 directory and not in /lib/<arch>/ as on Debian based build.

Fix #746

[rgaudin]

LGTM

[kelson42]

CI is red!

[mgautierfr]

CI is red!

Kiwix server is down :)

[kelson42]

@mgautierfr fixed, but windows-mixed still fails

[mgautierfr]

This is mostly broken because of kiwix/libkiwix#1116
I let you read the CI logs.

[kelson42]

@mgautierfr I have relaunched the CI this morning so it can benefit of latest nightly but this does not fix the problem. Not clear at all why the latest piece of code of libkiwix is not available OR maybe the version of libkiwix is not properly defined in14.0.0. In both cases, this is not clear where is the issue at this stage.

[rgaudin]

I see that both https://tmp.kiwix.org/ci/dev_preview/manylinux_archive/libzim_linux-x86_64-manylinux-2024-09-01.tar.gz does have the binary but it is in a lib64 sub-folder. Is this what we want?

I also see that https://tmp.kiwix.org/ci/dev_preview/manylinux_archive/libzim_linux-aarch64-manylinux-2024-09-01.tar.gz still doesn't include the binary.

[mgautierfr]

libkiwix is properly defined to 14. This is other projects which are looking for kiwix <14.
With kiwix/kiwix-tools#700 and kiwix/kiwix-desktop#1192 just merged this should be good.

[mgautierfr]

I see that both tmp.kiwix.org/ci/dev_preview/manylinux_archive/libzim_linux-x86_64-manylinux-2024-09-01.tar.gz does have the binary but it is in a lib64 sub-folder. Is this what we want?

I suppose too. manylinux is based on redhat and lib64 is where libraries goes on redhat. So I suppose that (in manylinux env at least) configuration is expecting that.

I also see that tmp.kiwix.org/ci/dev_preview/manylinux_archive/libzim_linux-aarch64-manylinux-2024-09-01.tar.gz still doesn't include the binary.

Will check
When cross compiling, we always put libraries in lib/<arch>.
New commit fix this (packaging, not where we put libraries)

[rgaudin]

I suppose too. manylinux is based on redhat and lib64 is where libraries goes on redhat. So I suppose that (in manylinux env at least) configuration is expecting that.

Except that those manylinux builds are not for redhat systems but for all older systems. Also, for aarch64, those wont be in lib64 because you cross-compile.

I am OK with the argument that “we simply copy what we have” though which is OK for most users. Automated tools like pylibzim will just have to rglob to find it.

[rgaudin]

👍

[mgautierfr]

What is recommendation from manylinux project ?
Or they don't care because they are about compiling and not packaging ?

[rgaudin]

It's just a shell for compiling. The packaging part is up to the project. We copy the lib inside our package manually. Our system mode (where it would look for it inside /lib64 I believe is only tailored for not-including libzim in package.

[kelson42]

@mgautierfr I guess we can merge and make a new build?!