Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: SearchWidget is not properly working. #4062

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Nov 7, 2024

Fixes #4059

  • Fixed: SearchWidget was not properly working, it was due to the direct casting of kClass not working, so we have improved our code to get the appName(which we are showing in the search widget).
  • Also, previously, the "Search" text was hardcoded in the SearchWidget, which can not be translated into other languages. So, to fix this, we are starting to use this from our string file so that the sentence can easily be translated into other languages.
XRecorder_07112024_123150.mp4
  • Fixed: When we click on the mic icon in the SearchWidget it opens the searchFragment but after searching through voice search it again opens the voice search(It does not search my voice search, same for if I press the back button the voice search again visible). It was due to the fragmentArguments we are passing for voice search was not clear, so due to this, it opened the voice search again and again. Also, the voice search was not working. So to fix this we have refactored our code.

Before Fix

ad72167e-5f4b-4315-a2ed-b45ea586f28f.mp4

After Fix

XRecorder_07112024_144353.mp4
  • Added the UI test cases for testing this scenario.
  • Improved MimeTypeTest, ZimFileReaderWithSplittedZimFileTest, and EncodedUrlTest test which sometimes failing on CI.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft November 7, 2024 07:06
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.92%. Comparing base (1576095) to head (8f56d73).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rg/kiwix/kiwixmobile/core/main/CoreSearchWidget.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4062      +/-   ##
============================================
+ Coverage     57.84%   57.92%   +0.08%     
- Complexity     1515     1517       +2     
============================================
  Files           315      315              
  Lines         13161    13166       +5     
  Branches       1676     1676              
============================================
+ Hits           7613     7627      +14     
  Misses         4448     4448              
+ Partials       1100     1091       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchWidget is not properly working.
2 participants