Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Kiwix opens in the Samsung file navigator. #4058

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Nov 6, 2024

Fixes #4048

  • We are now using the singleInstance launch mode instead of singleTop to prevent Kiwix from opening within the file manager.
  • Improved the handling of the GET_CONTENT shortcut(it was not properly working if the application was in the background).
XRecorder_06112024_183552.mp4

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft November 6, 2024 12:20
@MohitMaliFtechiz MohitMaliFtechiz changed the title Fixed: Kiwix now opens in the Samsung file navigator. Fixed: Kiwix opens in the Samsung file navigator. Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (4c773e2) to head (071dc96).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/kiwix/kiwixmobile/main/KiwixMainActivity.kt 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4058      +/-   ##
============================================
+ Coverage     57.81%   57.96%   +0.14%     
- Complexity     1515     1518       +3     
============================================
  Files           315      315              
  Lines         13161    13164       +3     
  Branches       1676     1675       -1     
============================================
+ Hits           7609     7630      +21     
+ Misses         4455     4441      -14     
+ Partials       1097     1093       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review November 6, 2024 13:33
@kelson42
Copy link
Collaborator

kelson42 commented Nov 6, 2024

@MohitMaliFtechiz Lint does not pass

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Nov 7, 2024

@MohitMaliFtechiz Lint does not pass

@kelson42 It is due to #4052. I will place a fix for this issue on upstream.

@kelson42 kelson42 merged commit 13951d3 into main Nov 7, 2024
16 of 20 checks passed
@kelson42 kelson42 deleted the Fixes#4048 branch November 7, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kiwix opens in Samsung file navigator
3 participants