Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Opening the zim file with kiwix fails to open(not showing the copy/move dialog). #4006

Merged
merged 17 commits into from
Oct 1, 2024

Refactored the CI to run test cases in separate jobs, as the emulator…

05eecc2
Select commit
Loading
Failed to load commit list.
Merged

Fixed: Opening the zim file with kiwix fails to open(not showing the copy/move dialog). #4006

Refactored the CI to run test cases in separate jobs, as the emulator…
05eecc2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 1, 2024 in 0s

58.13% (+0.27%) compared to a959978

View this Pull Request on Codecov

58.13% (+0.27%) compared to a959978

Details

Codecov Report

Attention: Patch coverage is 62.16216% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.13%. Comparing base (a959978) to head (05eecc2).

Files with missing lines Patch % Lines
...va/org/kiwix/kiwixmobile/main/KiwixMainActivity.kt 73.68% 3 Missing and 2 partials ⚠️
...le/nav/destination/library/LocalLibraryFragment.kt 58.33% 1 Missing and 4 partials ⚠️
...ile/nav/destination/library/CopyMoveFileHandler.kt 33.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4006      +/-   ##
============================================
+ Coverage     57.86%   58.13%   +0.27%     
+ Complexity     1602     1599       -3     
============================================
  Files           314      314              
  Lines         13109    13083      -26     
  Branches       1666     1659       -7     
============================================
+ Hits           7585     7606      +21     
+ Misses         4417     4373      -44     
+ Partials       1107     1104       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.